Skip to content

Add 手机百度 to the showcase page #9845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add 手机百度 to the showcase page #9845

wants to merge 5 commits into from

Conversation

zimengle
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Sep 12, 2016

By analyzing the blame information on this pull request, we identified @lacker and @alexleventer to be potential reviewers.

@ghost
Copy link

ghost commented Sep 12, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2016
@zimengle zimengle closed this Sep 12, 2016
@ghost
Copy link

ghost commented Sep 12, 2016

@zimengle updated the pull request - view changes

@zimengle zimengle reopened this Sep 12, 2016
@ghost
Copy link

ghost commented Sep 12, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2016
@nihgwu
Copy link
Contributor

nihgwu commented Sep 12, 2016

I think you can check this PR #9807 to refine yours for sooner merge

@ghost
Copy link

ghost commented Sep 12, 2016

@zimengle updated the pull request - view changes

@zimengle
Copy link
Contributor Author

@nihgwu refine done ，thanks

@ghost
Copy link

ghost commented Sep 12, 2016

@zimengle updated the pull request - view changes

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2016
lacker
lacker reviewed Sep 12, 2016
View reviewed changes
website/src/react-native/showcase.js Outdated
linkPlayStore: 'http://shouji.baidu.com/software/9896302.html',
linkAppStore: 'https://itunes.apple.com/en/app/shou-ji-bai-du-hai-liang-xin/id382201985?l=en&mt=8',
infoLink: 'http://baike.baidu.com/link?url=TW8YhcVN4tO_Jz5VqMclCjGhf12EEqMD_TeVC6efe2REZlx80r6T0dX96hdmNl36XogLyExXzrvFU9rFeqxg_K',
infoTitle: 'Baidu is a Search Engine APP that has been used by 600 millions users.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a grammatical nitpick: could you rephrase this sentence as:

"Baidu is a search engine that has 600 million users."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lacker done..thanks for your advice.

@ghost
Copy link

ghost commented Sep 13, 2016

@zimengle updated the pull request - view changes

@lacker
Copy link
Contributor

lacker commented Sep 13, 2016

@facebook-github-bot shipit

@ghost ghost added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Sep 13, 2016
@ghost
Copy link

ghost commented Sep 13, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2016
@ghost ghost closed this in 228abd4 Sep 13, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zimengle @nihgwu @lacker @facebook-github-bot