Omit anchors for headers in feed?

[Daniel15]

The RSS feed (http://facebook.github.io/react/feed.xml) has anchors and "#" links after headings:

<a class="anchor" name="migrating-to-babel"></a>Migrating to Babel <a class="hash-link" href="#migrating-to-babel">#</a>

This looks kinda ugly in feed readers, and doesn't really serve a purpose:

Most feed readers modify links so they're relative to the feed URL, so these links are actually becoming http://facebook.github.io/react/feed.xml#migrating-to-babel which doesn't do anything useful.

Can we remove these from the feed?

[zpao]

Not super easily right now since that's baked into the markdown processing (https://github.com/facebook/react/blob/master/docs/_plugins/header_links.rb)

[bryanbraun]

One option is to render them clientside, using a utility like AnchorJS. Anchors wouldn't appear in RSS since the feed content would leave the JS behind. It looks like all the same IDs would be generated, (it uses similar regex code to convert the titles to lowercase hyphen-delimited words).

Let me know if you're interested in that approach and I'll put together a pull request.

[sophiebits]

@bryanbraun Seems reasonable, though let's just inline the logic instead of pulling in a third-party library (and let's make sure the regex is equivalent in order to preserve existing links). Should only be a few lines of JS.

[bryanbraun]

See the approach at #4165. It uses the same regex patterns, so the links are backwards compatible.