Skip to content

Always wrap UMD bundles in IIFEs #10933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Always wrap UMD bundles in IIFEs #10933

wants to merge 2 commits into from

Conversation

@gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 28, 2017

Fixes #10909.

@gaearon
Copy link
Collaborator Author

gaearon commented Sep 28, 2017

Hmm.. This breaks Rollup's wrapper which uses this.

@gaearon gaearon closed this Sep 28, 2017
@gaearon gaearon mentioned this pull request Sep 28, 2017
Closed
@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 6b47743

https://deploy-preview-10933--reactjs.netlify.com

@asimen1 asimen1 mentioned this pull request Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sophiebits sophiebits Awaiting requested review from sophiebits

@trueadm trueadm Awaiting requested review from trueadm

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaearon @reactjs-bot @facebook-github-bot