Update ReactCoroutine-test to only use public API #11338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, these tests are currently testing apis that haven't been exposed publicly yet, so there isn't currently an actual public api to be used. For now, expose `createCoroutine` and `createYield` through the `ReactNoop` renderer, which is already used for testing (as per @gaearon's suggestion). When these apis are exposed publicly, these tests can be updated using that api. Part of #11299
|
@sebmarkbage Would you be okay with just exposing these as |
26 tasks
|
The more I thought about this the more sense it seemed to make to extract it to a separate package instead of tacking those onto the Noop reconciler. I was in the middle of a packaging change anyway the past few days so I went ahead and did it in #11364. So unfortunately I'm closing this. But I really appreciate that you sent this PR! It's what pushed me over the edge to actually address this :-) |
|
ah cool, no worries! :) |
This was referenced Dec 30, 2023
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, these tests are currently testing apis that haven't been exposed
publicly yet, so there isn't currently an actually public api to be used.
For now, expose
createCoroutineandcreateYieldthroughReactNooprenderer, which is already used for testing (as per @gaearon's suggestion).
When these apis are exposed publicly, these tests can be updated using that api.
Part of #11299