Put perf integration behind a feature flag #11455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
changed the title
trueadm
approved these changes
Nov 6, 2017
| export const enablePersistentReconciler = true; | ||
|
|
||
| export function addUserTimingListener() { | ||
| invariant(false, 'Not implemented.'); |
| export const enablePersistentReconciler = false; | ||
|
|
||
| export function addUserTimingListener() { | ||
| invariant(false, 'Not implemented.'); |
Contributor
|
fwiw I would really like a flag to expiriment with disabling this in devmode in open source. Our performance in development on React 16 has plummeted (it’s comparable in most scenarios in production with a few major regressions). The experiment is to see how much we’re paying for the usertiming integration in dev. |
Collaborator
Author
|
You can disable it manually in the npm bundle and then see if it helps :-) if it does, I'm open to exposing this somehow. |
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Enable User Timing API integration with a feature flag * Expose a way to toggle user timing flag in www * Update ReactNativeCSFeatureFlags.js * Update ReactFeatureFlags.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #11453.
The plan is to keep it
__DEV__only for open source, but enable it based on a feature flag internally so we can experiment with using it in production for some users.I have verified this doesn't inflate the open source build sizes.
I also exposed a ref counting interface to toggle the flag from www product code.