Skip to content

Fixed typo and jsdoc #13528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fixed typo and jsdoc #13528

wants to merge 6 commits into from

Conversation

@seunggabi
Copy link

@seunggabi seunggabi commented Sep 1, 2018

I fixed typos and jsdoc.
I remove unused variable (cancelWork) in schedule/index.html

ctrlaltvikas
ctrlaltvikas approved these changes Sep 1, 2018
View reviewed changes
Copy link

@ctrlaltvikas ctrlaltvikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure that its not being used anywhere.

@seunggabi
Copy link
Author

seunggabi commented Sep 1, 2018 •
edited
Loading

@vikaskyadav
I looked up cancelWork in project's all directory.
I don't find it. I found cancelWorkTimer instead.

So, I think cancelWork is not used.

@ctrlaltvikas
Copy link

ctrlaltvikas commented Sep 1, 2018 via email

@pull-bot
Copy link

pull-bot commented Sep 1, 2018 •
edited
Loading

Details of bundled changes.

Comparing: 8a1e396...54b9fab

react-scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-scheduler.development.js +24.4% +23.6% 15.4 KB 19.17 KB 4.65 KB 5.74 KB UMD_DEV
react-scheduler.production.min.js 🔺+15.8% 🔺+21.0% 2.73 KB 3.16 KB 1.26 KB 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@seunggabi
Copy link
Author

seunggabi commented Sep 1, 2018

I don't know why ci failed.

@NE-SmallTown
Copy link
Contributor

NE-SmallTown commented Sep 2, 2018 •
edited
Loading

I don't know why ci failed.

See #13509 (comment)

@seunggabi
Copy link
Author

seunggabi commented Sep 2, 2018

@NE-SmallTown
Is there anything I need to fix? (for ci success)
(I saw other PR's ci failed.)

@seunggabi
Copy link
Author

seunggabi commented Sep 21, 2018

@vikaskyadav Excuse me.. Do you know when this will be merged? I'm curious.
If you know, tell me~ thanks!

@seunggabi
Copy link
Author

seunggabi commented Aug 15, 2019

@vikaskyadav
I think, this PR don't need
So I close this PR.

Thank you about your review :)

@seunggabi seunggabi closed this Aug 15, 2019
@seunggabi seunggabi deleted the fixed-typo-and-jsdoc branch August 15, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ctrlaltvikas ctrlaltvikas ctrlaltvikas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seunggabi @ctrlaltvikas @pull-bot @NE-SmallTown @facebook-github-bot