Skip to content

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 24, 2020

This includes #18380 but doesn't include #18377 so that I could still layer it on top.

gaearon added 5 commits March 24, 2020 20:38
This fixes the bug.
These aren't directly observable. The arg wasn't used, it's accidental and I forgot to remove. The retval was triggering a codepath that was unnecessary (pushing to array) so I removed that too.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 24, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 664b936:

Sandbox Source
suspicious-https-41zgn Configuration

@sizebot
Copy link

sizebot commented Mar 24, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 664b936

@sizebot
Copy link

sizebot commented Mar 24, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 664b936

@gaearon gaearon closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants