Skip to content

Conversation

@gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 31, 2020

Reverts #19502

I just noticed we have it planned under 18 in Quip. So unless we decide otherwise, let's keep it off.

@gaearon gaearon merged commit 332ecef into master Jul 31, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e061825:

Sandbox Source
React Configuration

@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Jul 31, 2020
@sizebot
Copy link

sizebot commented Jul 31, 2020

Details of bundled changes.

Comparing: 815ee89...e061825

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.1% 917.26 KB 916.65 KB 208.66 KB 208.54 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 🔺+0.1% 398.71 KB 398.88 KB 73.94 KB 73.98 KB FB_WWW_PROD
react-dom-server.node.development.js -0.4% -0.4% 139.49 KB 138.87 KB 36.85 KB 36.72 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 124.2 KB 124.16 KB 39.82 KB 39.8 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% +0.1% 413.96 KB 414.13 KB 76.69 KB 76.73 KB FB_WWW_PROFILING
react-dom-server.browser.development.js -0.4% -0.4% 145.7 KB 145.06 KB 37.05 KB 36.91 KB UMD_DEV
react-dom-server.node.production.min.js -0.2% -0.2% 20.76 KB 20.72 KB 7.69 KB 7.67 KB NODE_PROD
ReactDOMTesting-dev.js -0.1% -0.1% 952.67 KB 951.89 KB 213.74 KB 213.58 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.0% -0.0% 402.59 KB 402.52 KB 75.82 KB 75.81 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 5.61 KB 5.61 KB 1.86 KB 1.87 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.36 KB 5.36 KB 1.8 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.17 KB 1.17 KB 667 B 666 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.2 KB 1.2 KB 705 B 706 B UMD_PROD
ReactTestUtils-dev.js +0.2% +0.1% 55.19 KB 55.29 KB 15.48 KB 15.5 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 4.87 KB 4.87 KB 1.7 KB 1.71 KB NODE_DEV
react-dom.development.js -0.1% -0.1% 963.63 KB 962.99 KB 211.29 KB 211.16 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 124.08 KB 124.03 KB 40.56 KB 40.55 KB UMD_PROD
react-dom.profiling.min.js -0.0% -0.0% 129.26 KB 129.22 KB 42.19 KB 42.19 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 993.9 KB 994.1 KB 221.25 KB 221.3 KB FB_WWW_DEV
react-dom.profiling.min.js -0.0% -0.0% 129.59 KB 129.55 KB 41.46 KB 41.45 KB NODE_PROFILING
react-dom-server.browser.production.min.js -0.2% -0.1% 20.42 KB 20.38 KB 7.55 KB 7.54 KB UMD_PROD
ReactDOM-dev.js 0.0% 0.0% 986.55 KB 986.74 KB 220.29 KB 220.34 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 🔺+0.1% 394.97 KB 395.14 KB 73.35 KB 73.39 KB FB_WWW_PROD
react-dom-server.browser.development.js -0.4% -0.4% 138.22 KB 137.6 KB 36.6 KB 36.47 KB NODE_DEV
ReactDOM-profiling.js 0.0% +0.1% 409.37 KB 409.54 KB 75.98 KB 76.02 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js -0.2% -0.2% 20.34 KB 20.3 KB 7.53 KB 7.52 KB NODE_PROD
ReactDOMServer-dev.js +0.1% +0.1% 143.24 KB 143.44 KB 36.45 KB 36.48 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+0.3% 🔺+0.2% 46.53 KB 46.68 KB 10.9 KB 10.93 KB FB_WWW_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against e061825

@sizebot
Copy link

sizebot commented Jul 31, 2020

Details of bundled changes.

Comparing: 815ee89...e061825

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.1% -0.1% 880.15 KB 879.54 KB 201.9 KB 201.78 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 0.0% 409.85 KB 410.02 KB 75.63 KB 75.65 KB FB_WWW_PROD
react-dom-server.node.development.js -0.4% -0.4% 137.97 KB 137.36 KB 36.64 KB 36.5 KB NODE_DEV
react-dom.production.min.js -0.0% -0.0% 119.41 KB 119.37 KB 38.39 KB 38.38 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% 0.0% 425.16 KB 425.33 KB 78.34 KB 78.37 KB FB_WWW_PROFILING
react-dom-server.browser.development.js -0.4% -0.4% 144.11 KB 143.48 KB 36.85 KB 36.72 KB UMD_DEV
react-dom-server.node.production.min.js -0.2% -0.2% 20.3 KB 20.26 KB 7.62 KB 7.6 KB NODE_PROD
ReactDOMTesting-dev.js -0.1% -0.1% 980.83 KB 980.05 KB 219.15 KB 218.99 KB FB_WWW_DEV
ReactDOMTesting-prod.js -0.0% -0.0% 414.84 KB 414.77 KB 77.66 KB 77.65 KB FB_WWW_PROD
ReactTestUtils-dev.js +0.2% +0.2% 55.19 KB 55.29 KB 15.47 KB 15.49 KB FB_WWW_DEV
react-dom.development.js -0.1% -0.1% 924.72 KB 924.08 KB 204.41 KB 204.29 KB UMD_DEV
react-dom.production.min.js -0.0% -0.0% 119.35 KB 119.31 KB 39.09 KB 39.08 KB UMD_PROD
react-dom.profiling.min.js -0.0% 0.0% 123.25 KB 123.21 KB 40.28 KB 40.28 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 1019.45 KB 1019.64 KB 225.99 KB 226.03 KB FB_WWW_DEV
react-dom.profiling.min.js -0.0% -0.0% 123.48 KB 123.44 KB 39.64 KB 39.63 KB NODE_PROFILING
react-dom-server.browser.production.min.js -0.2% -0.1% 19.96 KB 19.92 KB 7.47 KB 7.46 KB UMD_PROD
ReactDOM-dev.js 0.0% 0.0% 1012.09 KB 1012.29 KB 225 KB 225.03 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 406.1 KB 406.27 KB 75.01 KB 75.03 KB FB_WWW_PROD
react-dom-server.browser.development.js -0.5% -0.4% 136.7 KB 136.09 KB 36.39 KB 36.26 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 420.56 KB 420.73 KB 77.63 KB 77.66 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js -0.2% -0.2% 19.88 KB 19.84 KB 7.46 KB 7.44 KB NODE_PROD
ReactDOMServer-dev.js +0.1% +0.1% 147.27 KB 147.47 KB 37.45 KB 37.48 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+0.3% 🔺+0.3% 47.4 KB 47.54 KB 11.11 KB 11.14 KB FB_WWW_PROD

Size changes (stable)

Generated by 🚫 dangerJS against e061825

@kassens kassens deleted the revert-19502-enable-empty-flag branch November 17, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants