- 
                Notifications
    
You must be signed in to change notification settings  - Fork 49.7k
 
Scheduling Profiler: Move preprocessing to web worker and add loading indicator #19759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            5 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      915b051
              
                Move preprocessData into a web worker
              
              
                taneliang cb5fed0
              
                Add UI feedback for loading/import error states
              
              
                taneliang 3a54937
              
                Terminate worker when done handling profile
              
              
                taneliang 842af41
              
                Add display density CSS variables
              
              
                taneliang cd1f3c4
              
                Replace error boundary with manual error handling
              
              
                taneliang File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            13 changes: 13 additions & 0 deletions
          
          13 
        
  packages/react-devtools-scheduling-profiler/src/import-worker/InvalidProfileError.js
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @flow | ||
| */ | ||
| 
     | 
||
| /** | ||
| * An error thrown when an invalid profile could not be processed. | ||
| */ | ||
| export default class InvalidProfileError extends Error {} | 
            File renamed without changes.
          
    
            File renamed without changes.
          
    
        
          
          
            57 changes: 57 additions & 0 deletions
          
          57 
        
  packages/react-devtools-scheduling-profiler/src/import-worker/import.worker.js
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @flow | ||
| */ | ||
| 
     | 
||
| import 'regenerator-runtime/runtime'; | ||
| 
     | 
||
| import type {TimelineEvent} from '@elg/speedscope'; | ||
| import type {ReactProfilerData} from '../types'; | ||
| 
     | 
||
| import preprocessData from './preprocessData'; | ||
| import {readInputData} from './readInputData'; | ||
| import InvalidProfileError from './InvalidProfileError'; | ||
| 
     | 
||
| declare var self: DedicatedWorkerGlobalScope; | ||
| 
     | 
||
| type ImportWorkerInputData = {| | ||
| file: File, | ||
| |}; | ||
| 
     | 
||
| export type ImportWorkerOutputData = | ||
| | {|status: 'SUCCESS', processedData: ReactProfilerData|} | ||
| | {|status: 'INVALID_PROFILE_ERROR', error: Error|} | ||
| | {|status: 'UNEXPECTED_ERROR', error: Error|}; | ||
                
      
                  bvaughn marked this conversation as resolved.
               
          
            Show resolved
            Hide resolved
         | 
||
| 
     | 
||
| self.onmessage = async function(event: MessageEvent) { | ||
| const {file} = ((event.data: any): ImportWorkerInputData); | ||
| 
     | 
||
| try { | ||
| const readFile = await readInputData(file); | ||
| const events: TimelineEvent[] = JSON.parse(readFile); | ||
| if (events.length === 0) { | ||
| throw new InvalidProfileError('No profiling data found in file.'); | ||
| } | ||
| 
     | 
||
| self.postMessage({ | ||
| status: 'SUCCESS', | ||
| processedData: preprocessData(events), | ||
| }); | ||
| } catch (error) { | ||
| if (error instanceof InvalidProfileError) { | ||
| self.postMessage({ | ||
| status: 'INVALID_PROFILE_ERROR', | ||
| error, | ||
| }); | ||
| } else { | ||
| self.postMessage({ | ||
| status: 'UNEXPECTED_ERROR', | ||
| error, | ||
| }); | ||
| } | ||
| } | ||
| }; | ||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not sure if storing data + import errors in a resource is the cleanest approach. I'm doing this to handle these expected/intentional errors without throwing them and using error boundaries. Any idea how I can improve this?