Skip to content

Use toMatchInlineSnapshot for dehydrated values #20618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 26, 2021
Merged

Use toMatchInlineSnapshot for dehydrated values #20618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4581f56
Revert "You're killing me, Jest"
eps1lon Jan 19, 2021
a579f5d
Fix false-positive snapshot mismatch
eps1lon Jan 19, 2021
9c0650b
Fix date mismatch
eps1lon Jan 19, 2021
ee699c0
Try normalizing TZ across environments instead of changing the previe…
eps1lon Apr 8, 2021
56fcc69
Use same pattern in custom snapshot serializers
eps1lon Apr 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react-devtools-shared/src/__tests__/dehydratedValueSerializer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@
// test() is part of Jest's serializer API
export function test(maybeDehydratedValue) {
const {meta} = require('react-devtools-shared/src/hydration');

const hasOwnProperty = Object.prototype.hasOwnProperty.bind(
maybeDehydratedValue,
);
return (
maybeDehydratedValue !== null &&
typeof maybeDehydratedValue === 'object' &&
maybeDehydratedValue.hasOwnProperty(meta.inspectable) &&
hasOwnProperty(meta.inspectable) &&
maybeDehydratedValue[meta.inspected] !== true
);
}
Expand Down
Loading