Skip to content

Make enterleave plugin not depend on window level listener #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make enterleave plugin not depend on window level listener #2066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/browser/eventPlugins/EnterLeaveEventPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ var EnterLeaveEventPlugin = {
* For almost every interaction we care about, there will be both a top-level
* `mouseover` and `mouseout` event that occurs. Only use `mouseout` so that
* we do not extract duplicate events. However, moving the mouse into the
* browser from outside will not fire a `mouseout` event. In this case, we use
* element from outside will not fire a `mouseout` event. In this case, we use
* the `mouseover` top-level event.
*
* @param {string} topLevelType Record from `EventConstants`.
Expand All @@ -71,16 +71,22 @@ var EnterLeaveEventPlugin = {
topLevelTarget,
topLevelTargetID,
nativeEvent) {
if (topLevelType === topLevelTypes.topMouseOver &&
(nativeEvent.relatedTarget || nativeEvent.fromElement)) {
return null;
}
if (topLevelType !== topLevelTypes.topMouseOut &&
topLevelType !== topLevelTypes.topMouseOver) {
// Must not be a mouse in or mouse out - ignoring.
// Unrelated event.
return null;
}

if (topLevelType === topLevelTypes.topMouseOver) {
// `fromElement`/`toElement` are IE's equivalent of `relatedTarget`.
var relatedTarget = nativeEvent.relatedTarget || nativeEvent.fromElement;
// See docblock above. Ignore all `mouseover` unless they come from
// outside of the top-level event listening container.
if (relatedTarget && ReactMount.getFirstReactDOM(relatedTarget) != null) {
return null;
}
}

var win;
if (topLevelTarget.window === topLevelTarget) {
// `topLevelTarget` is probably a window object.
Expand Down