Skip to content

Conversation

@lunaruan
Copy link
Contributor

This PR adds the reactVersion pragma to tests.

Tests without the reactVersion pragma won't be run if the reactVersion pragma isn't specified.

Tested each React version manually with the pragma to make sure the tests pass

@lunaruan lunaruan requested review from bvaughn and mondaychen May 18, 2022 15:16
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 18, 2022
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just scanned quickly. Assuming the tests all pass on CI, this change seems fine 😄

@lunaruan lunaruan force-pushed the test_react_version branch from 3fb0101 to 63a9dd4 Compare May 18, 2022 15:29
@lunaruan lunaruan merged commit b77c125 into facebook:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants