Skip to content

Conversation

@lunaruan
Copy link
Contributor

string.replaceAll doesn't exist in our CircleCI Docker environment. We also don't need it in this case because semver.satisfies allows for whitespace when specifying a range. This PR removes the unnecessary call.

@lunaruan lunaruan requested review from bvaughn and mondaychen May 19, 2022 14:50
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 19, 2022
@sizebot
Copy link

sizebot commented May 19, 2022

Comparing: 835d9c9...80ea95c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.49 kB 131.49 kB = 42.15 kB 42.15 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.73 kB 136.73 kB = 43.69 kB 43.69 kB
facebook-www/ReactDOM-prod.classic.js = 441.13 kB 441.13 kB = 80.41 kB 80.41 kB
facebook-www/ReactDOM-prod.modern.js = 426.34 kB 426.34 kB = 78.23 kB 78.23 kB
facebook-www/ReactDOMForked-prod.classic.js = 441.13 kB 441.13 kB = 80.42 kB 80.42 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 80ea95c

@lunaruan lunaruan merged commit 6e2f38f into facebook:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants