Skip to content

Conversation

@lunaruan
Copy link
Contributor

This PR:

  • Increases test retry count to 2 so that flaky tests have more of a chance to pass
  • Ideally most e2e tests will run for all React versions (and ensure DevTools elegantly fails if React doesn't support its features). However, some features aren't supported in older React versions at all (ex. Profiling) Add runOnlyForReactRange function in these cases to skip tests that don't satisfy the correct React semver range
  • Fix should allow searching for component by name test, which was flaky because sometimes the Searchbox would be unfocused the second time we try to type in it
  • Edited test Should allow elements to be inspected to check that element inspect gracefully fails in older React versions
  • Updated config to add a config.use.url field and a config.use.react_version field, which change depending on the React Version (and whether it's specified)

@lunaruan lunaruan requested review from bvaughn and mondaychen May 25, 2022 22:00
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 25, 2022
@lunaruan lunaruan merged commit 1328ff7 into facebook:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants