Skip to content

[DevTools] Modify DevTools e2e test script for regression tests #24642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022
Merged

[DevTools] Modify DevTools e2e test script for regression tests #24642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions scripts/circleci/run_devtools_e2e_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const {spawn} = require('child_process');
const {join} = require('path');

const ROOT_PATH = join(__dirname, '..', '..');

const reactVersion = process.argv[2];
const inlinePackagePath = join(ROOT_PATH, 'packages', 'react-devtools-inline');
const shellPackagePath = join(ROOT_PATH, 'packages', 'react-devtools-shell');

Expand Down Expand Up @@ -74,7 +74,15 @@ function runTestShell() {

logBright('Starting testing shell server');

serverProcess = spawn('yarn', ['start'], {cwd: shellPackagePath});
if (!reactVersion) {
serverProcess = spawn('yarn', ['start'], {cwd: shellPackagePath});
} else {
serverProcess = spawn('yarn', ['start'], {
cwd: shellPackagePath,
env: {...process.env, REACT_VERSION: reactVersion},
});
}

serverProcess.stdout.on('data', data => {
if (`${data}`.includes('Compiled successfully.')) {
logBright('Testing shell server running');
Expand Down Expand Up @@ -106,8 +114,15 @@ function runTestShell() {

async function runEndToEndTests() {
logBright('Running e2e tests');
if (!reactVersion) {
testProcess = spawn('yarn', ['test:e2e'], {cwd: inlinePackagePath});
} else {
testProcess = spawn('yarn', ['test:e2e'], {
cwd: inlinePackagePath,
env: {...process.env, REACT_VERSION: reactVersion},
});
}

testProcess = spawn('yarn', ['test:e2e'], {cwd: inlinePackagePath});
testProcess.stdout.on('data', data => {
// Log without formatting because Playwright applies its own formatting.
const formatted = format(data);
Expand Down