[DevTools][BE] Read username using gh in release script #25270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: e7fc04b...8940bbe Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
kassens
approved these changes
Sep 15, 2022
scripts/devtools/prepare-release.js
Outdated
| line = line.replace('[DevTools] ', ''); | ||
|
|
||
| for (let line of rawLog.split('\n')) { | ||
| line = line.replace(/^\[[dD]ev[tT]ools\]? /, ''); |
There was a problem hiding this comment.
With the i flag for case insensitive this simplifies a bit. I also think you have the ? not where intended (optional ], but you probably wanted to strip optional spaces. * matches any number of spaces.
Suggested change
| line = line.replace(/^\[[dD]ev[tT]ools\]? /, ''); | |
| line = line.replace(/^\[devtools\] */i, ''); |
rickhanlonii
pushed a commit
that referenced
this pull request
Oct 5, 2022
* [DevTools][BE] Read username using gh in release script * better regex & fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script required manually filling github names in the changelog, this PR is to automate this process.
If
ghis installed, use github API to fetch PR author.Also, improves
[DevTools]tag removal.Some of generated change log looks like the following: