Skip to content

Conversation

lushevol
Copy link
Contributor

@lushevol lushevol commented Dec 6, 2022

Summary

Remove the invalid link which points to react-devtools-extensions/src/_tests_ in CONTRIBUTING.md, as it's already moved to react-devtools-shared/src/_tests_ in #22260.

How did you test this change?

By run yarn test and yarn lint.

```

# Unit tests
Core DevTools functionality is typically unit tested (see [here](https://github.com/facebook/react/tree/main/packages/react-devtools-shared/src/__tests__) and [here](https://github.com/facebook/react/tree/main/packages/react-devtools-extensions/src/__tests__)). To run tests, you'll first need to build or download React and React DOM ([as explained above](#build-react-and-react-dom)) and then use the following NPM script:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed tests were moved to shared in #22260 so it's fine to simply delete

@eps1lon
Copy link
Collaborator

eps1lon commented Dec 6, 2022

Thanks!

@eps1lon eps1lon merged commit 7db45b9 into facebook:main Dec 6, 2022
github-actions bot pushed a commit that referenced this pull request Dec 6, 2022
DiffTrain build for `7db45b9a38b8d1b5b945756cf38a174c1ec6118a`
@lushevol lushevol deleted the fix-link-in-contributing-doc-of-devtools branch December 6, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants