Skip to content

Ship diffInCommitPhase #27409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2023
Merged

Ship diffInCommitPhase #27409

merged 1 commit into from
Sep 23, 2023

Conversation

@sophiebits
Copy link
Collaborator

Performance tests at Meta showed neutral results.

@sophiebits
Ship diffInCommitPhase
976cb67 
Performance tests at Meta showed neutral results.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 23, 2023
@react-sizebot
Copy link

Comparing: d9e00f7...976cb67

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.47% 166.66 kB 167.45 kB +0.02% 52.14 kB 52.15 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 176.10 kB 176.11 kB = 54.98 kB 54.84 kB
facebook-www/ReactDOM-prod.classic.js = 571.96 kB 563.33 kB = 100.66 kB 99.28 kB
facebook-www/ReactDOM-prod.modern.js = 555.68 kB 547.06 kB = 97.77 kB 96.35 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-dom/cjs/react-dom.production.min.js +0.47% 166.59 kB 167.37 kB +0.02% 52.11 kB 52.12 kB
oss-stable/react-dom/cjs/react-dom.production.min.js +0.47% 166.66 kB 167.45 kB +0.02% 52.14 kB 52.15 kB
oss-stable-semver/react-dom/umd/react-dom.production.min.js +0.47% 166.45 kB 167.23 kB = 52.53 kB 52.44 kB
oss-stable/react-dom/umd/react-dom.production.min.js +0.47% 166.53 kB 167.31 kB = 52.55 kB 52.47 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js +0.45% 176.22 kB 177.01 kB +0.04% 54.55 kB 54.57 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js +0.45% 176.30 kB 177.09 kB +0.03% 54.57 kB 54.59 kB
oss-stable-semver/react-dom/umd/react-dom.profiling.min.js +0.44% 175.44 kB 176.22 kB = 54.86 kB 54.82 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js +0.44% 175.52 kB 176.30 kB = 54.88 kB 54.85 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 42.64 kB 42.28 kB = 9.62 kB 9.57 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 42.64 kB 42.28 kB = 9.62 kB 9.57 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 42.64 kB 42.28 kB = 9.62 kB 9.57 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js = 42.51 kB 42.15 kB = 9.60 kB 9.55 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js = 42.51 kB 42.15 kB = 9.60 kB 9.55 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js = 42.51 kB 42.15 kB = 9.60 kB 9.55 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 15.64 kB 15.49 kB = 4.68 kB 4.66 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 15.64 kB 15.49 kB = 4.68 kB 4.66 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 15.64 kB 15.49 kB = 4.68 kB 4.66 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 15.57 kB 15.42 kB = 4.67 kB 4.65 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 15.57 kB 15.42 kB = 4.67 kB 4.65 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 15.57 kB 15.42 kB = 4.67 kB 4.65 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,462.74 kB 1,447.40 kB = 315.68 kB 313.45 kB
facebook-www/ReactDOM-dev.classic.js = 1,444.40 kB 1,429.05 kB = 311.25 kB 309.00 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,434.84 kB 1,419.49 kB = 309.98 kB 307.85 kB
facebook-www/ReactDOM-dev.modern.js = 1,416.49 kB 1,401.15 kB = 305.54 kB 303.44 kB
facebook-www/ReactDOM-profiling.classic.js = 602.54 kB 593.93 kB = 105.15 kB 103.81 kB
facebook-www/ReactDOM-profiling.modern.js = 586.19 kB 577.58 kB = 102.28 kB 100.93 kB
facebook-www/ReactDOMTesting-prod.classic.js = 586.77 kB 578.15 kB = 104.38 kB 103.01 kB
facebook-www/ReactDOMTesting-prod.modern.js = 572.22 kB 563.60 kB = 101.88 kB 100.51 kB
facebook-www/ReactDOM-prod.classic.js = 571.96 kB 563.33 kB = 100.66 kB 99.28 kB
facebook-www/ReactDOM-prod.modern.js = 555.68 kB 547.06 kB = 97.77 kB 96.35 kB

Generated by 🚫 dangerJS against 976cb67

@sophiebits sophiebits merged commit 7f62018 into facebook:main Sep 23, 2023
github-actions bot pushed a commit that referenced this pull request Sep 23, 2023
@sophiebits
Ship diffInCommitPhase (#27409)
dff0ebb 
Performance tests at Meta showed neutral results.

DiffTrain build for [7f62018](7f62018)
@shuding shuding mentioned this pull request Sep 26, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Sep 26, 2023
@shuding
Update vendored React (#56012)
974e41c 
### React upstream changes

- facebook/react#27417
- facebook/react#27408
- facebook/react#27409
- facebook/react#27405
- facebook/react#27375
- facebook/react#27407
- facebook/react#27365
- facebook/react#27399
- facebook/react#27395
- facebook/react#27394
- facebook/react#27397
- facebook/react#26992
- facebook/react#27388
- facebook/react#27373
- facebook/react#27332
@saurabharch saurabharch mentioned this pull request Nov 28, 2023
Open
@leftrightleft leftrightleft mentioned this pull request Nov 29, 2023
Open
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@sophiebits @AndyPengc12
Ship diffInCommitPhase (facebook#27409)
adbcf23 
Performance tests at Meta showed neutral results.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@sophiebits
Ship diffInCommitPhase (#27409)
d2cd2f2 
Performance tests at Meta showed neutral results.

DiffTrain build for commit 7f62018.
@eps1lon eps1lon mentioned this pull request Apr 25, 2024
Merged
@fossabot fossabot bot mentioned this pull request Oct 2, 2025
Open
@fossabot fossabot bot mentioned this pull request Oct 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sophiebits @react-sizebot @sebmarkbage @facebook-github-bot