Skip to content

Set disableModulePatternComponents flag to __NEXT_MAJOR__ for RN OSS #28581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Set disableModulePatternComponents flag to __NEXT_MAJOR__ for RN OSS #28581

wants to merge 1 commit into from

Conversation

kassens
Copy link
Member

@kassens kassens commented Mar 18, 2024

Set disableModulePatternComponents flag to NEXT_MAJOR for RN OSS

I missed this in #28579, for the next major of RN OSS we should also
enable this flag.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 18, 2024
kassens
kassens commented Mar 18, 2024
View reviewed changes
packages/shared/forks/ReactFeatureFlags.native-oss.js
export const enableTrustedTypesIntegration = false;
export const disableTextareaChildren = false;
export const disableModulePatternComponents = false;
export const disableModulePatternComponents = __NEXT_MAJOR__;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that __NEXT_MAJOR__ is just false for now in RN OSS defined above. This is just a reminder when we do that upgrade.

@react-sizebot
Copy link

react-sizebot commented Mar 18, 2024 •
edited
Loading

Comparing: a493901...d3bf58a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.84 kB 176.84 kB = 54.92 kB 54.92 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.27 kB 173.27 kB = 54.04 kB 54.04 kB
facebook-www/ReactDOM-prod.classic.js = 594.30 kB 594.30 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 577.56 kB 577.56 kB = 101.48 kB 101.48 kB
test_utils/ReactAllWarnings.js Deleted 66.48 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.48 kB 0.00 kB Deleted 16.26 kB 0.00 kB

Generated by 🚫 dangerJS against d3bf58a

@kassens
Set disableModulePatternComponents flag to __NEXT_MAJOR__ for RN OSS
d3bf58a 
I missed this in facebook#28579, for the next major of RN OSS we should also
enable this flag.
@kassens kassens requested a review from rickhanlonii March 20, 2024 16:04
rickhanlonii
rickhanlonii approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when you rebase it should be __TODO_NEXT_RN_MAJOR__ which keeps it as false and not __NEXT_RN_MAJOR__ which would flip it to true.

@kassens
Copy link
Member Author

kassens commented Mar 25, 2024

Already fixed in fabd6d3

@kassens kassens closed this Mar 25, 2024
@kassens kassens deleted the pr28581 branch March 25, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kassens @react-sizebot @rickhanlonii @facebook-github-bot