Skip to content

Hardcode enableLegacyFBSupport flag #28701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

Hardcode enableLegacyFBSupport flag #28701

merged 1 commit into from
Apr 2, 2024
+1 −2

Conversation

@kassens
Copy link
Member

@kassens kassens commented Apr 1, 2024 •
edited
Loading

Hardcode enableLegacyFBSupport flag

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 1, 2024
@react-sizebot
Copy link

react-sizebot commented Apr 1, 2024 •
edited
Loading

Comparing: e3afd02...38cac23

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.97 kB 176.97 kB = 55.00 kB 55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.83 kB 172.83 kB = 53.88 kB 53.88 kB
facebook-www/ReactDOM-prod.classic.js = 591.42 kB 591.26 kB = 103.76 kB 103.73 kB
facebook-www/ReactDOM-prod.modern.js = 573.15 kB 573.00 kB = 100.81 kB 100.79 kB
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.93 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against 38cac23

@kassens kassens requested a review from rickhanlonii April 1, 2024 18:42
@kassens kassens merged commit ba5496d into facebook:main Apr 2, 2024
@kassens kassens deleted the pr28701 branch April 2, 2024 15:35
github-actions bot pushed a commit that referenced this pull request Apr 2, 2024
@kassens
Hardcode enableLegacyFBSupport flag (#28701)
9350ce4 
Hardcode enableLegacyFBSupport flag

DiffTrain build for [ba5496d](ba5496d)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@kassens @AndyPengc12
Hardcode enableLegacyFBSupport flag (facebook#28701)
95077cc 
Hardcode enableLegacyFBSupport flag
This was referenced Apr 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackpope jackpope jackpope approved these changes

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kassens @react-sizebot @jackpope @facebook-github-bot