Skip to content

[tests] assertLog before act in ReactCompositeComponentState #28758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2024
Merged

[tests] assertLog before act in ReactCompositeComponentState #28758

merged 1 commit into from
Apr 10, 2024

Conversation

@rickhanlonii
Copy link
Member

Fixes tests blocking #28737

@rickhanlonii rickhanlonii requested a review from acdlite April 5, 2024 14:46
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 5, 2024
@react-sizebot
Copy link

Comparing: a5aedd1...8e338ea

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 169.31 kB 169.31 kB = 52.76 kB 52.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.13 kB 171.13 kB = 53.33 kB 53.33 kB
facebook-www/ReactDOM-prod.classic.js = 588.80 kB 588.80 kB = 103.63 kB 103.63 kB
facebook-www/ReactDOM-prod.modern.js = 565.82 kB 565.82 kB = 99.54 kB 99.54 kB
test_utils/ReactAllWarnings.js Deleted 64.21 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.21 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 8e338ea

@rickhanlonii rickhanlonii mentioned this pull request Apr 5, 2024
Merged
eps1lon
eps1lon approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good example why individual assertions are better than just one batch at the end 👍🏻

@rickhanlonii rickhanlonii merged commit e36ee76 into facebook:main Apr 10, 2024
rickhanlonii added a commit that referenced this pull request Apr 10, 2024
@rickhanlonii
[tests] Assert scheduler log empty in internalAct (#28737)
3f947b1 
We should force `assertLog` to be called before each `act` block to
ensure the queue is empty.

Requires fixing tests:
- #28745
- #28758
- #28759
- #28760
- #28761
- #28762
- #28763
- #28812
rickhanlonii added a commit that referenced this pull request Apr 11, 2024
@rickhanlonii
[tests] assertLog before act in ReactCompositeComponentState (#28758)
0de7847 
Fixes tests blocking #28737
rickhanlonii added a commit that referenced this pull request Apr 11, 2024
@rickhanlonii
[tests] Assert scheduler log empty in internalAct (#28737)
1be7039 
We should force `assertLog` to be called before each `act` block to
ensure the queue is empty.

Requires fixing tests:
- #28745
- #28758
- #28759
- #28760
- #28761
- #28762
- #28763
- #28812
rickhanlonii added a commit that referenced this pull request Apr 11, 2024
@rickhanlonii
[tests] assertLog before act in ReactCompositeComponentState (#28758)
f9fccf9 
Fixes tests blocking #28737
rickhanlonii added a commit that referenced this pull request Apr 11, 2024
@rickhanlonii
[tests] Assert scheduler log empty in internalAct (#28737)
4151551 
We should force `assertLog` to be called before each `act` block to
ensure the queue is empty.

Requires fixing tests:
- #28745
- #28758
- #28759
- #28760
- #28761
- #28762
- #28763
- #28812
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@rickhanlonii @AndyPengc12
[tests] assertLog before act in ReactCompositeComponentState (faceboo…
d552b27 
…k#28758)

Fixes tests blocking facebook#28737
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@rickhanlonii @AndyPengc12
[tests] Assert scheduler log empty in internalAct (facebook#28737)
8af02aa 
We should force `assertLog` to be called before each `act` block to
ensure the queue is empty.

Requires fixing tests:
- facebook#28745
- facebook#28758
- facebook#28759
- facebook#28760
- facebook#28761
- facebook#28762
- facebook#28763
- facebook#28812
This was referenced Apr 24, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes

@acdlite acdlite Awaiting requested review from acdlite

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickhanlonii @react-sizebot @eps1lon @facebook-github-bot