Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented May 21, 2024

Summary

assertConsoleErrorDev([
  ['Hello', {withoutStack: true}]
])

now errors with a helpful diff message if the message mismatched. See first commit for previous behavior.

How did you test this change?

  • yarn test --watch packages/internal-test-utils/__tests__/ReactInternalTestUtils-test.js

@vercel
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 3:44pm

@react-sizebot
Copy link

react-sizebot commented May 21, 2024

Comparing: 6f90365...6a01abd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 495.71 kB 495.71 kB = 88.78 kB 88.78 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 500.51 kB 500.51 kB = 89.47 kB 89.47 kB
facebook-www/ReactDOM-prod.classic.js = 592.86 kB 592.86 kB = 104.28 kB 104.28 kB
facebook-www/ReactDOM-prod.modern.js = 569.08 kB 569.08 kB = 100.70 kB 100.70 kB
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Generated by 🚫 dangerJS against 6a01abd

@eps1lon eps1lon changed the title Fix ReactJSXElementValidator tests Fix assertConsoleErrorDev on message mismatch with withoutStack: true May 21, 2024
@eps1lon eps1lon force-pushed the assertConsoleErrorDev-withoutStack-mismatch branch from cd1070e to 6a01abd Compare May 21, 2024 15:41
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ty

@rickhanlonii rickhanlonii merged commit 5cc9f69 into facebook:main May 21, 2024
@eps1lon eps1lon deleted the assertConsoleErrorDev-withoutStack-mismatch branch May 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants