Skip empty sync commits (both repos) #29707
Merged
+164
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: d77dd31...554476c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
yungsters
approved these changes
Jun 2, 2024
| id: get_last_version | ||
| run: | | ||
| VERSION_CLASSIC=$(cat ./compiled/facebook-www/VERSION_CLASSIC) | ||
| VERSION_MODERN=$(cat ./compiled/facebook-www/VERSION_MODERN) |
There was a problem hiding this comment.
Maybe add a safety check here to make sure the version number is well formed.
There was a problem hiding this comment.
Hm, not sure about that, it would be nice to change the format without breaking the sync.
| git status | ||
| echo "Status to check" | ||
| git status --porcelain | grep -qv '/REVISION$' | ||
| if git status --porcelain | grep -qv '/REVISION'; then |
There was a problem hiding this comment.
How come you have $ above but not here?
There was a problem hiding this comment.
The www file is REVISION or REVISION_TRANSFORMS but the fbsource one is just REVISION
rickhanlonii
force-pushed
the
rh/skip-commits
branch
from
bcfb223 to
16e34dd
Compare
rickhanlonii
changed the title
|
Ah crap, I meant to merge the other diff. @yungsters I think I addressed everything in your review, but if you want to review the new changes here I can submit a PR with more changes. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
Requires #29706 The strategy here is to: - Checkout the builds/facebook-www branch - Read the current sync'd VERSION - Checkout out main and sync new build - sed/{new version string}/{old version string} - Run git status, skip sync if clean - Otherwise, sed/{old version string}/{new version string} and push commit This means that: - We're using the real version strings from the builds - We are checking the last commit on the branch for the real last version - We're skipping any commits that won't result in changes - ??? - Profit! DiffTrain build for commit 5ad2c37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #29706
The strategy here is to:
This means that: