Skip to content

Conversation

yossydev
Copy link

@yossydev yossydev commented Jun 10, 2024

Summary

The parsePluginOptions seemed to be duplicated within BabelPlugin.ts and Program.ts.
Since the options already parsed in BabelPlugin.ts should have been passed to compileProgram, in this PR we deleted parsePluginOptions in compileProgram and used the options passed as arguments as they are. I've done that.

How did you test this change?

image

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 11:12pm

@react-sizebot
Copy link

react-sizebot commented Jun 10, 2024

Comparing: 6b35ff7...bc3765c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.44 kB 497.44 kB = 89.16 kB 89.16 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.26 kB 502.26 kB = 89.85 kB 89.85 kB
facebook-www/ReactDOM-prod.classic.js = 596.94 kB 596.94 kB = 105.24 kB 105.24 kB
facebook-www/ReactDOM-prod.modern.js = 571.12 kB 571.12 kB = 101.19 kB 101.19 kB
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Generated by 🚫 dangerJS against bc3765c

Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch, thanks!

@poteto
Copy link
Member

poteto commented Jun 10, 2024

also please run yarn prettier:write!

@yossydev yossydev force-pushed the remove-duplicate-parsePluginOptions branch from 8cdc67d to bc3765c Compare June 10, 2024 23:07
@yossydev
Copy link
Author

also please run yarn prettier:write!

Thank you for your review!
I ran yarn prettire:write and pushed!

@josephsavona
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants