Skip to content

[compiler] HIR-based FlattenReactiveLoops #29838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

[compiler] HIR-based FlattenReactiveLoops #29838

merged 1 commit into from
Jun 11, 2024

Conversation

josephsavona
Copy link
Member

@josephsavona josephsavona commented Jun 10, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Pre the title, this implements an HIR-based version of FlattenReactiveLoops. Another step on the way to HIR-everywhere.

@josephsavona
[compiler] HIR-based FlattenReactiveLoops
4d760f6 
Pre the title, this implements an HIR-based version of FlattenReactiveLoops. Another step on the way to HIR-everywhere.

[ghstack-poisoned]
@vercel Vercel
Copy link

vercel bot commented Jun 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 8:26pm

@josephsavona josephsavona mentioned this pull request Jun 10, 2024
Merged
josephsavona added a commit that referenced this pull request Jun 10, 2024
@josephsavona
[compiler] HIR-based FlattenReactiveLoops
a121d04 
Pre the title, this implements an HIR-based version of FlattenReactiveLoops. Another step on the way to HIR-everywhere.

ghstack-source-id: e1d1663
Pull Request resolved: #29838
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 10, 2024
@react-sizebot
Copy link

Comparing: d172bda...4d760f6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.44 kB 497.44 kB = 89.16 kB 89.16 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.26 kB 502.26 kB = 89.85 kB 89.85 kB
facebook-www/ReactDOM-prod.classic.js = 596.94 kB 596.94 kB = 105.24 kB 105.24 kB
facebook-www/ReactDOM-prod.modern.js = 571.12 kB 571.12 kB = 101.19 kB 101.19 kB
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.89 kB 0.00 kB Deleted 15.97 kB 0.00 kB

Generated by 🚫 dangerJS against 4d760f6

@josephsavona josephsavona mentioned this pull request Jun 10, 2024
Merged
mofeiZ
mofeiZ reviewed Jun 11, 2024
View reviewed changes
compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/FlattenReactiveLoopsHIR.ts
}
case "scope": {
if (activeLoops.length !== 0) {
block.terminal = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_soclean!!

@josephsavona josephsavona merged commit 4d760f6 into gh/josephsavona/29/base Jun 11, 2024
josephsavona added a commit that referenced this pull request Jun 11, 2024
@josephsavona
[compiler] HIR-based FlattenReactiveLoops
43c17d1 
Pre the title, this implements an HIR-based version of FlattenReactiveLoops. Another step on the way to HIR-everywhere.

ghstack-source-id: e1d1663
Pull Request resolved: #29838
@josephsavona josephsavona deleted the gh/josephsavona/29/head branch June 11, 2024 15:35
@eps1lon eps1lon mentioned this pull request Jun 13, 2024
Merged
@eps1lon eps1lon mentioned this pull request Jul 10, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mofeiZ mofeiZ mofeiZ approved these changes

Assignees

No one assigned

Labels

CLA Signed Component: React Compiler React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josephsavona @react-sizebot @mofeiZ @facebook-github-bot