[compiler] Enable sourceMaps in tsconfig

[gsathya]

With this, we can set a debugger breakpoint and we'll break into the source code when running tests with snap. Without this, we'd break into the transpiled js code.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 25, 2024 11:21am

[react-sizebot]

Comparing: 7608516...cbe43c3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.68 kB	6.68 kB	=	1.83 kB	1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	=	497.93 kB	497.93 kB	=	89.26 kB	89.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.69 kB	6.69 kB	=	1.84 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	=	502.75 kB	502.75 kB	=	89.96 kB	89.96 kB
facebook-www/ReactDOM-prod.classic.js	=	597.17 kB	597.17 kB	=	105.33 kB	105.33 kB
facebook-www/ReactDOM-prod.modern.js	=	571.52 kB	571.52 kB	=	101.27 kB	101.27 kB
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Generated by 🚫 dangerJS against cbe43c3

[josephsavona]

nice!

[poteto]

Would you mind seeing if you can add this option to the virtual tsconfig instead?: https://github.com/facebook/react/blob/main/compiler/packages/snap/src/runner-watch.ts#L30

The downside of changing tsconfig directly is that it affects our build and generates extra files that will be included in npm. And if we can help it I'd rather not have any source maps in there because it's unnecessary for a build-time only module plus bloats the package size a bit.

[gsathya]

Would you mind seeing if you can add this option to the virtual tsconfig instead?

Done

[poteto]

thank you!! 🤍🤍🤍