Skip to content

[Flight Server] Run Server Components in console.createTask when available #30140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

[Flight Server] Run Server Components in console.createTask when available #30140

merged 1 commit into from
Jul 1, 2024
+40 −4

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Jun 29, 2024 •
edited
Loading

Same as #30142 but for Flight Server.

This is rarely used but it does allow seeing component stacks when inspecting the Node.js server running Flight using --inspect and the Chrome DevTools.

Screenshot 2024-06-29 at 1 08 47 PM

@sebmarkbage
Run Server Components in console.createTask when available
9f7a7dc 
This is rarely used but it does allow seeing component stacks when
inspecting the Node.js server running Flight.
@sebmarkbage sebmarkbage requested review from eps1lon and gnoff June 29, 2024 17:11
@vercel Vercel
Copy link

vercel bot commented Jun 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 5:13pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 29, 2024
@react-sizebot
Copy link

Comparing: 2e72ea8...9f7a7dc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.99 kB 497.99 kB = 89.27 kB 89.27 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.81 kB 502.81 kB = 89.97 kB 89.97 kB
facebook-www/ReactDOM-prod.classic.js = 597.08 kB 597.08 kB = 105.33 kB 105.33 kB
facebook-www/ReactDOM-prod.modern.js = 571.42 kB 571.42 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.52% 136.96 kB 137.68 kB +0.41% 25.53 kB 25.64 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.52% 137.11 kB 137.83 kB +0.40% 25.59 kB 25.70 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.48% 92.12 kB 92.56 kB +0.46% 17.13 kB 17.21 kB
oss-stable-rc/react-server/cjs/react-server-flight.development.js +0.46% 80.45 kB 80.82 kB +0.25% 15.00 kB 15.03 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js +0.46% 80.45 kB 80.82 kB +0.25% 15.00 kB 15.03 kB
oss-stable/react-server/cjs/react-server-flight.development.js +0.46% 80.45 kB 80.82 kB +0.25% 15.00 kB 15.03 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.43% 132.05 kB 132.61 kB +0.35% 24.74 kB 24.82 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.41% 138.41 kB 138.98 kB +0.36% 25.71 kB 25.80 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.41% 138.58 kB 139.14 kB +0.35% 25.77 kB 25.86 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.40% 139.52 kB 140.08 kB +0.35% 25.96 kB 26.05 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.40% 139.67 kB 140.23 kB +0.34% 26.02 kB 26.11 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.32% 135.80 kB 136.23 kB +0.28% 25.32 kB 25.39 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.32% 136.42 kB 136.85 kB +0.28% 25.49 kB 25.56 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.28% 120.27 kB 120.61 kB +0.16% 22.50 kB 22.54 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.28% 120.27 kB 120.61 kB +0.16% 22.50 kB 22.54 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.28% 120.27 kB 120.61 kB +0.16% 22.50 kB 22.54 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.27% 124.16 kB 124.50 kB +0.15% 23.10 kB 23.13 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.27% 124.16 kB 124.50 kB +0.15% 23.10 kB 23.13 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.27% 124.16 kB 124.50 kB +0.15% 23.10 kB 23.13 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.27% 124.79 kB 125.12 kB +0.15% 23.27 kB 23.31 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.27% 124.79 kB 125.12 kB +0.15% 23.27 kB 23.31 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.27% 124.79 kB 125.12 kB +0.15% 23.27 kB 23.31 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.27% 124.99 kB 125.33 kB +0.14% 23.27 kB 23.31 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.27% 124.99 kB 125.33 kB +0.14% 23.27 kB 23.31 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.27% 124.99 kB 125.33 kB +0.14% 23.27 kB 23.31 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.27% 125.14 kB 125.48 kB +0.13% 23.34 kB 23.37 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.27% 125.14 kB 125.48 kB +0.13% 23.34 kB 23.37 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.27% 125.14 kB 125.48 kB +0.13% 23.34 kB 23.37 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.27% 126.63 kB 126.97 kB +0.14% 23.45 kB 23.48 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.27% 126.63 kB 126.97 kB +0.14% 23.45 kB 23.48 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.27% 126.63 kB 126.97 kB +0.14% 23.45 kB 23.48 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.27% 126.79 kB 127.13 kB +0.13% 23.51 kB 23.54 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.27% 126.79 kB 127.13 kB +0.13% 23.51 kB 23.54 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.27% 126.79 kB 127.13 kB +0.13% 23.51 kB 23.54 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.27% 127.74 kB 128.08 kB +0.13% 23.72 kB 23.75 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.27% 127.74 kB 128.08 kB +0.13% 23.72 kB 23.75 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.27% 127.74 kB 128.08 kB +0.13% 23.72 kB 23.75 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.27% 127.89 kB 128.23 kB +0.13% 23.78 kB 23.81 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.27% 127.89 kB 128.23 kB +0.13% 23.78 kB 23.81 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.27% 127.89 kB 128.23 kB +0.13% 23.78 kB 23.81 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against 9f7a7dc

@sebmarkbage sebmarkbage mentioned this pull request Jun 29, 2024
Merged
@sebmarkbage sebmarkbage merged commit d40ea87 into facebook:main Jul 1, 2024
sebmarkbage added a commit that referenced this pull request Jul 1, 2024
@sebmarkbage
[Fizz] Run console.createTask during SSR when available (#30142)
e6783e7 
Same as #30140 but for Fizz.

This is rarely used but it does allow seeing component stacks when
inspecting the Node.js server running Fizz using `--inspect` and the
Chrome DevTools.

<img width="504" alt="Screenshot 2024-06-29 at 4 08 22 PM"
src="https://github.com/facebook/react/assets/63648/f89bdf89-2598-42b4-8623-3b87f03326c4">
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes

@gnoff gnoff Awaiting requested review from gnoff

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebmarkbage @react-sizebot @eps1lon @facebook-github-bot