[compiler][eslint] Use logger callback instead of exceptions to report eslint diagnostics #30336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t eslint diagnostics [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
…ns to report eslint diagnostics" [ghstack-poisoned]
This was referenced Jul 15, 2024
mofeiZ
commented
Jul 15, 2024
Comment on lines
+176
to
+179
| { | ||
| message: | ||
| "Mutating component props or hook arguments is not allowed. Consider using a local variable instead", | ||
| }, |
There was a problem hiding this comment.
Previous to this PR, the second error would not be reported
…ns to report eslint diagnostics" --- * panicThreshold: `all_errors` -> `none` * inject an error logger through compiler config (instead of using exceptions) We currently report at most one lint warning per file, this lets us exhaustively report all available ones (see new test fixture for example) [ghstack-poisoned]
mofeiZ
added a commit
that referenced
this pull request
Jul 15, 2024
…t eslint diagnostics --- * panicThreshold: `all_errors` -> `none` * inject an error logger through compiler config (instead of using exceptions) We currently report at most one lint warning per file, this lets us exhaustively report all available ones (see new test fixture for example) ghstack-source-id: 5299315 Pull Request resolved: #30336
|
nice! |
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
…t eslint diagnostics --- * panicThreshold: `all_errors` -> `none` * inject an error logger through compiler config (instead of using exceptions) We currently report at most one lint warning per file, this lets us exhaustively report all available ones (see new test fixture for example) ghstack-source-id: 5299315 Pull Request resolved: facebook#30336
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
…t eslint diagnostics --- * panicThreshold: `all_errors` -> `none` * inject an error logger through compiler config (instead of using exceptions) We currently report at most one lint warning per file, this lets us exhaustively report all available ones (see new test fixture for example) ghstack-source-id: 5299315 Pull Request resolved: facebook#30336
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
all_errors->noneWe currently report at most one lint warning per file, this lets us exhaustively report all available ones (see new
test fixture for example)