[ci][ez] Rename artifact from process_artifacts_combined #30364
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Jul 17, 2024
Build artifacts are uniquely associated to a single workflow run, so appending the sha was unnecessary. I originally included it to make it easier to download later but this turns out to be unneeded. Drops the sha suffix to make downloading the artifact in a separate script / workflow more straightforward. ghstack-source-id: 36ac4df Pull Request resolved: #30364
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 163365a...0e0f470 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
jackpope
approved these changes
Jul 17, 2024
| # TODO: Migrate scripts to use `build` directory instead of `build2` | ||
| - run: cp ./build.tgz ./build2.tgz | ||
| - name: Archive build artifacts | ||
| uses: actions/upload-artifact@v4 |
poteto
added a commit
that referenced
this pull request
Jul 18, 2024
Build artifacts are uniquely associated to a single workflow run, so appending the sha was unnecessary. I originally included it to make it easier to download later but this turns out to be unneeded. Drops the sha suffix to make downloading the artifact in a separate script / workflow more straightforward. ghstack-source-id: 36ac4df Pull Request resolved: #30364
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Build artifacts are uniquely associated to a single workflow run, so appending the sha was unnecessary. I originally included it to make it easier to download later but this turns out to be unneeded. Drops the sha suffix to make downloading the artifact in a separate script / workflow more straightforward. ghstack-source-id: 36ac4df Pull Request resolved: facebook#30364
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Build artifacts are uniquely associated to a single workflow run, so appending the sha was unnecessary. I originally included it to make it easier to download later but this turns out to be unneeded. Drops the sha suffix to make downloading the artifact in a separate script / workflow more straightforward. ghstack-source-id: 36ac4df Pull Request resolved: facebook#30364
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Build artifacts are uniquely associated to a single workflow run, so
appending the sha was unnecessary. I originally included it to make it
easier to download later but this turns out to be unneeded.
Drops the sha suffix to make downloading the artifact in a separate
script / workflow more straightforward.