[circleci] Inline scrape_warning_messages #30388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 18, 2024
facebook-github-bot
added
the
React Core Team
|
Comparing: 512b09b...8ba5dc4 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
added a commit
that referenced
this pull request
Jul 18, 2024
This job was only being used for process_artifacts_combined in circleci but as it was a separate job would incur the cost and time of spinning up a new CI worker. We can simply inline this into process_artifacts_combined. Test plan: Download [build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts) from circleci and observe that the __test_utils__ directory is still present. ghstack-source-id: 8748d8f Pull Request resolved: #30388
poteto
added a commit
that referenced
this pull request
Jul 18, 2024
This job was only being used for process_artifacts_combined in circleci but as it was a separate job would incur the cost and time of spinning up a new CI worker. We can simply inline this into process_artifacts_combined. Test plan: Download [build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts) from circleci and observe that the __test_utils__ directory is still present. ghstack-source-id: 8748d8f Pull Request resolved: #30388
poteto
added a commit
that referenced
this pull request
Jul 18, 2024
This job was only being used for process_artifacts_combined in circleci but as it was a separate job would incur the cost and time of spinning up a new CI worker. We can simply inline this into process_artifacts_combined. Test plan: Download [build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts) from circleci and observe that the __test_utils__ directory is still present. ghstack-source-id: 8748d8f Pull Request resolved: #30388
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
This job was only being used for process_artifacts_combined in circleci but as it was a separate job would incur the cost and time of spinning up a new CI worker. We can simply inline this into process_artifacts_combined. Test plan: Download [build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts) from circleci and observe that the __test_utils__ directory is still present. ghstack-source-id: 8748d8f Pull Request resolved: facebook#30388
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
This job was only being used for process_artifacts_combined in circleci but as it was a separate job would incur the cost and time of spinning up a new CI worker. We can simply inline this into process_artifacts_combined. Test plan: Download [build.tgz](https://app.circleci.com/pipelines/github/facebook/react/57183/workflows/3b22a99e-b8a5-4c80-9682-576f24581b00/jobs/956476/artifacts) from circleci and observe that the __test_utils__ directory is still present. ghstack-source-id: 8748d8f Pull Request resolved: facebook#30388
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This job was only being used for process_artifacts_combined in circleci
but as it was a separate job would incur the cost and time of spinning
up a new CI worker. We can simply inline this into
process_artifacts_combined.
Test plan: Download
build.tgz
from circleci and observe that the test_utils directory is still
present.