Skip to content

[compiler][patch] Don't wrap non-ascii fbt operands in JSXExpressionContainer #30389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2024
Merged

[compiler][patch] Don't wrap non-ascii fbt operands in JSXExpressionContainer #30389

merged 3 commits into from
Jul 18, 2024

Conversation

mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Jul 18, 2024 •
edited
Loading

This was referenced Jul 18, 2024
Merged
Merged
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 7:40pm

mofeiZ added a commit that referenced this pull request Jul 18, 2024
@mofeiZ
[compiler][patch] Don't wrap non-ascii jsx operands in JSXExpressionC…
534d3e4 
…ontainer

ghstack-source-id: 4b5505a
Pull Request resolved: #30389
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 18, 2024
mofeiZ added a commit that referenced this pull request Jul 18, 2024
@mofeiZ
[compiler][patch] Don't wrap non-ascii jsx operands in JSXExpressionC…
7147e1f 
…ontainer

ghstack-source-id: 4b5505a
Pull Request resolved: #30389
@mofeiZ mofeiZ changed the title [compiler][patch] Don't wrap non-ascii jsx operands in JSXExpressionContainer [compiler][patch] Don't wrap non-ascii fbt operands in JSXExpressionContainer Jul 18, 2024
mofeiZ added a commit that referenced this pull request Jul 18, 2024
@mofeiZ
[compiler][patch] Don't wrap non-ascii fbt operands in JSXExpressionC…
8a7f2b3 
…ontainer

ghstack-source-id: 4b5505a
Pull Request resolved: #30389
@mofeiZ mofeiZ marked this pull request as ready for review July 18, 2024 19:36
@react-sizebot
Copy link

react-sizebot commented Jul 18, 2024 •
edited
Loading

Comparing: 512b09b...02c64b9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.30 kB 90.30 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.79 kB 105.79 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Generated by 🚫 dangerJS against 02c64b9

poteto
poteto approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@poteto poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fbt 💀

@mofeiZ mofeiZ merged commit 02c64b9 into gh/mofeiZ/13/base Jul 18, 2024
mofeiZ added a commit that referenced this pull request Jul 18, 2024
@mofeiZ
[compiler][patch] Don't wrap non-ascii fbt operands in JSXExpressionC…
b2ec044 
…ontainer

ghstack-source-id: 4b5505a
Pull Request resolved: #30389
@mofeiZ mofeiZ deleted the gh/mofeiZ/13/head branch July 18, 2024 20:18
@eps1lon eps1lon mentioned this pull request Jul 23, 2024
Closed
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
@felixshiftellecon
[compiler][patch] Don't wrap non-ascii fbt operands in JSXExpressionC…
09c7078 
…ontainer

ghstack-source-id: 4b5505a
Pull Request resolved: facebook#30389
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
@felixshiftellecon
[compiler][patch] Don't wrap non-ascii fbt operands in JSXExpressionC…
0ec25f1 
…ontainer

ghstack-source-id: 4b5505a
Pull Request resolved: facebook#30389
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poteto poteto poteto approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mofeiZ @react-sizebot @poteto @facebook-github-bot