Remove forceConcurrentByDefaultForTesting flag #30436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: e2cac67...0cbdb62 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
kassens
approved these changes
Jul 23, 2024
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Concurrent by default has been unshipped! Let's clean it up. Here we remove `forceConcurrentByDefaultForTesting`, which allows us to run tests against both concurrent strategies. In the next PR, we'll remove the actual concurrent by default code path.
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Concurrent by default has been unshipped! Let's clean it up. Here we remove `forceConcurrentByDefaultForTesting`, which allows us to run tests against both concurrent strategies. In the next PR, we'll remove the actual concurrent by default code path.
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Concurrent by default has been unshipped! Let's clean it up. Here we remove `forceConcurrentByDefaultForTesting`, which allows us to run tests against both concurrent strategies. In the next PR, we'll remove the actual concurrent by default code path.
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
Concurrent by default has been unshipped! Let's clean it up. Here we remove `forceConcurrentByDefaultForTesting`, which allows us to run tests against both concurrent strategies. In the next PR, we'll remove the actual concurrent by default code path.
jackpope
added a commit
that referenced
this pull request
Jul 25, 2024
Following #30436 Concurrent by default strategy has been unshipped. Here we clean up the `allowConcurrentByDefault` path and related logic/tests. For now, this keeps the `concurrentUpdatesByDefaultOverride` argument in `createContainer` and `createHydrationContainer` and ignores the value to prevent more breaking changes to `react-reconciler` in the RC stage.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Following #30436 Concurrent by default strategy has been unshipped. Here we clean up the `allowConcurrentByDefault` path and related logic/tests. For now, this keeps the `concurrentUpdatesByDefaultOverride` argument in `createContainer` and `createHydrationContainer` and ignores the value to prevent more breaking changes to `react-reconciler` in the RC stage. DiffTrain build for commit 14a4699.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Following #30436 Concurrent by default strategy has been unshipped. Here we clean up the `allowConcurrentByDefault` path and related logic/tests. For now, this keeps the `concurrentUpdatesByDefaultOverride` argument in `createContainer` and `createHydrationContainer` and ignores the value to prevent more breaking changes to `react-reconciler` in the RC stage. DiffTrain build for [14a4699](14a4699)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent by default has been unshipped! Let's clean it up.
Here we remove
forceConcurrentByDefaultForTesting, which allows us to run tests against both concurrent strategies. In the next PR, we'll remove the actual concurrent by default code path.