[compiler] Fix FBT whitespace handling again (again (again)) #30451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Jul 24, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
React Core Team
[ghstack-poisoned]
Fbt whitespace rules apply to their entire jsx subtrees, not just direct children (testing internally in progress) [ghstack-poisoned]
This was referenced Jul 25, 2024
mvitousek
approved these changes
Jul 25, 2024
| * whitespace as is. | ||
| * https://github.com/facebook/fbt/blob/0b4e0d13c30bffd0daa2a75715d606e3587b4e40/packages/babel-plugin-fbt/src/FbtUtil.js#L76-L87 | ||
| */ | ||
| // text = exprPath.node.value.replace(/[^\S\u00A0]+/g, ' '); |
| * Increment fbt counter before traversing into children, as whitespace | ||
| * in jsx text is handled differently for fbt subtrees. | ||
| */ | ||
| isFbt && builder.fbtDepth++; |
There was a problem hiding this comment.
Maybe include in the isFbt conditional block directly above?
There was a problem hiding this comment.
Ah I figured this might be cleaner (keeping the increment / decrement next the recursive call), but I don't have strong opinions here. Happy to fix forward if you think that's a cleaner pattern
There was a problem hiding this comment.
No strong opinions here :)
Fbt whitespace rules apply to their entire jsx subtrees, not just direct children (testing internally in progress) [ghstack-poisoned]
Fbt whitespace rules apply to their entire jsx subtrees, not just direct children. Since fbt transform runs after react-compiler, let's just retain all whitespace as is. Tested internally by diffing fbt compilation tables (with and without react-compiler in the pipeline). See results here https://fburl.com/diff/t43dopfg. Note there are no differences except for 2 edge cases in which `babel-transform-fbt` fails to dedupe some table entries. [ghstack-poisoned]
josephsavona
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fbt whitespace rules apply to their entire jsx subtrees, not just direct children. Since fbt transform runs after react-compiler, let's just retain all whitespace as is.
Tested internally by diffing fbt compilation tables (with and without react-compiler in the pipeline). See results here https://fburl.com/diff/t43dopfg. Note there are no differences except for 2 edge cases in which
babel-transform-fbtfails to dedupe some table entries. This can help us be more confident that this fix covers all edge cases (without adding all permutations of fbt whitespace / elements to test fixtures)