Skip to content

[ci] Cleanup run_devtools_e2e_tests #30467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

[ci] Cleanup run_devtools_e2e_tests #30467

merged 1 commit into from
Jul 25, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 25, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

This was only used for build_and_test which has since been migrated to
gh actions and is now therefore unused. Looks like I missed this during
the previous cleanup.

@poteto
Update
9771cb9 
[ghstack-poisoned]
@vercel
Copy link

vercel bot commented Jul 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 9:08pm

poteto added a commit that referenced this pull request Jul 25, 2024
@poteto
[ci] Cleanup run_devtools_e2e_tests
106a343 
This was only used for build_and_test which has since been migrated to
gh actions and is now therefore unused. Looks like I missed this during
the previous cleanup.

ghstack-source-id: 2784439
Pull Request resolved: #30467
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 25, 2024
kassens
kassens approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@kassens kassens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@react-sizebot
Copy link

Comparing: a0e7ecf...7acf593

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.39 kB 501.39 kB = 89.96 kB 89.96 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.21 kB 506.21 kB = 90.66 kB 90.66 kB
facebook-www/ReactDOM-prod.classic.js = 598.83 kB 598.83 kB = 105.76 kB 105.76 kB
facebook-www/ReactDOM-prod.modern.js = 574.94 kB 574.94 kB = 101.99 kB 101.99 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 9771cb9

@poteto poteto merged commit 9771cb9 into gh/poteto/35/base Jul 25, 2024
poteto added a commit that referenced this pull request Jul 25, 2024
@poteto
[ci] Cleanup run_devtools_e2e_tests
0a76aec 
This was only used for build_and_test which has since been migrated to
gh actions and is now therefore unused. Looks like I missed this during
the previous cleanup.

ghstack-source-id: 2784439
Pull Request resolved: #30467
@poteto poteto deleted the gh/poteto/35/head branch July 25, 2024 21:09
@eps1lon eps1lon mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kassens kassens kassens approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@poteto @react-sizebot @kassens @facebook-github-bot