Skip to content

[ci] Fix ci prep script #30499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024
+2 −93
Merged

[ci] Fix ci prep script #30499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 0 additions & 75 deletions scripts/release/shared-commands/get-build-id-for-commit.js
View file
Open in desktop

This file was deleted.

20 changes: 2 additions & 18 deletions scripts/release/shared-commands/parse-params.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
'use strict';

const commandLineArgs = require('command-line-args');
const getBuildIdForCommit = require('./get-build-id-for-commit');
const theme = require('../theme');
const {logPromise} = require('../utils');

const paramDefinitions = [
{
Expand Down Expand Up @@ -59,22 +57,8 @@ module.exports = async () => {
process.exit(1);
}

if (params.build === null && params.commit === null) {
console.error(
theme.error`Either a --commit or --build param must be specified.`
);
process.exit(1);
}

try {
if (params.build === null) {
params.build = await logPromise(
getBuildIdForCommit(params.commit, params.allowBrokenCI),
theme`Getting build ID for commit "${params.commit}"`
);
}
} catch (error) {
console.error(theme.error(error));
if (params.commit === null) {
console.error(theme.error`A --commit param must be specified.`);
process.exit(1);
}

Expand Down