[fresh] Reset useMemoCache in response to a FastRefresh run #30677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Aug 13, 2024
This PR introduces a new debug property on fibers to indicate that it is being rerendered as a result of a FastRefresh run. This allows React to clear the cache even where the size (incidentally) remains constant between renders: for example, if edited code _happens_ to keep the cache size the same but the code is meaningfully different such that it is no longer correct to reuse the cache. ghstack-source-id: 4984a38 Pull Request resolved: #30677
facebook-github-bot
added
the
React Core Team
|
Comparing: dd8e0ba...d2d5f30 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
poteto
added a commit
that referenced
this pull request
Aug 13, 2024
This PR introduces a new (dev only) debug property on fibers to indicate that it is being rerendered as a result of a FastRefresh run. This allows React to clear the cache even where the size (incidentally) remains constant between renders: for example, if edited code _happens_ to keep the cache size the same but the code is meaningfully different such that it is no longer correct to reuse the cache. ghstack-source-id: 4984a38 Pull Request resolved: #30677
poteto
changed the title
poteto
added a commit
that referenced
this pull request
Aug 13, 2024
This PR introduces a new (dev only) debug property on fibers to indicate that it is being rerendered as a result of a FastRefresh run. This allows React to clear the cache even where the size (incidentally) remains constant between renders: for example, if edited code _happens_ to keep the cache size the same but the code is meaningfully different such that it is no longer correct to reuse the cache. ghstack-source-id: 4984a38 Pull Request resolved: #30677
poteto
added a commit
that referenced
this pull request
Aug 13, 2024
This PR introduces a new (dev only) debug property on fibers to indicate that it is being rerendered as a result of a FastRefresh run. This allows React to clear the cache even where the size (incidentally) remains constant between renders: for example, if edited code _happens_ to keep the cache size the same but the code is meaningfully different such that it is no longer correct to reuse the cache. ghstack-source-id: 9bf49f9 Pull Request resolved: #30677
|
Is it possible to use the module-level |
|
Also noticing the test passes even if I comment out |
poteto
added a commit
that referenced
this pull request
Aug 14, 2024
This PR introduces a new (dev only) debug property on fibers to indicate that it is being rerendered as a result of a FastRefresh run. This allows React to clear the cache even where the size (incidentally) remains constant between renders: for example, if edited code _happens_ to keep the cache size the same but the code is meaningfully different such that it is no longer correct to reuse the cache. ghstack-source-id: d4b4758 Pull Request resolved: #30677
poteto
added a commit
that referenced
this pull request
Aug 14, 2024
This PR introduces a new (dev only) debug property on fibers to indicate that it is being rerendered as a result of a FastRefresh run. This allows React to clear the cache even where the size (incidentally) remains constant between renders: for example, if edited code _happens_ to keep the cache size the same but the code is meaningfully different such that it is no longer correct to reuse the cache. ghstack-source-id: 2e14ae4 Pull Request resolved: #30677
|
I think #30700 makes sense to me, any reason why we don't do that instead? |
|
Closing in favor of #30700 |
gaearon
added a commit
that referenced
this pull request
Aug 15, 2024
Stacked on #30662. Alternative to #30663 and #30677. During a Fast Refresh, we always want to evict the memo cache, same as we do with normal `useMemo`. The mechanism used by `useMemo` and other Hooks is this module-level variable: https://github.com/facebook/react/blob/fca5d655d78917400a2722287351c20938166669/packages/react-reconciler/src/ReactFiberHooks.js#L304-L307 which has DEV-only behavior as if the dependencies are always different: https://github.com/facebook/react/blob/fca5d655d78917400a2722287351c20938166669/packages/react-reconciler/src/ReactFiberHooks.js#L451-L460 The `useMemoCache` Hook doesn't use a dependency array but conceptually I think we want the same behavior. ## Test Plan The test passes. --------- Co-authored-by: Lauren Tan <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
Stacked on #30662. Alternative to #30663 and #30677. During a Fast Refresh, we always want to evict the memo cache, same as we do with normal `useMemo`. The mechanism used by `useMemo` and other Hooks is this module-level variable: https://github.com/facebook/react/blob/fca5d655d78917400a2722287351c20938166669/packages/react-reconciler/src/ReactFiberHooks.js#L304-L307 which has DEV-only behavior as if the dependencies are always different: https://github.com/facebook/react/blob/fca5d655d78917400a2722287351c20938166669/packages/react-reconciler/src/ReactFiberHooks.js#L451-L460 The `useMemoCache` Hook doesn't use a dependency array but conceptually I think we want the same behavior. ## Test Plan The test passes. --------- Co-authored-by: Lauren Tan <[email protected]> DiffTrain build for [7e8a06c](7e8a06c)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
Stacked on #30662. Alternative to #30663 and #30677. During a Fast Refresh, we always want to evict the memo cache, same as we do with normal `useMemo`. The mechanism used by `useMemo` and other Hooks is this module-level variable: https://github.com/facebook/react/blob/fca5d655d78917400a2722287351c20938166669/packages/react-reconciler/src/ReactFiberHooks.js#L304-L307 which has DEV-only behavior as if the dependencies are always different: https://github.com/facebook/react/blob/fca5d655d78917400a2722287351c20938166669/packages/react-reconciler/src/ReactFiberHooks.js#L451-L460 The `useMemoCache` Hook doesn't use a dependency array but conceptually I think we want the same behavior. ## Test Plan The test passes. --------- Co-authored-by: Lauren Tan <[email protected]> DiffTrain build for commit 7e8a06c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR introduces a new (dev only) debug property on fibers to indicate
that it is being rerendered as a result of a FastRefresh run. This
allows React to clear the cache even where the size (incidentally)
remains constant between renders: for example, if edited code happens
to keep the cache size the same but the code is meaningfully different
such that it is no longer correct to reuse the cache.