Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Aug 14, 2024

Summary

Less subtle of a difference while allowing us to provide APIs for different render targets. Can't publish yet as nightlies since I need to invite the bot first to the package.

How did you test this change?

  • N/A

@vercel
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 7:53am

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 14, 2024
@react-sizebot
Copy link

react-sizebot commented Aug 14, 2024

Comparing: 2a54019...49b4756

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.56 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB
oss-experimental/react-markup/cjs/react-markup.development.js +∞% 0.00 kB 341.64 kB +∞% 0.00 kB 62.38 kB
oss-experimental/react-markup/cjs/react-markup.production.js +∞% 0.00 kB 203.03 kB +∞% 0.00 kB 38.23 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js +∞% 0.00 kB 497.36 kB +∞% 0.00 kB 89.52 kB
oss-experimental/react-markup/cjs/react-markup.react-server.production.js +∞% 0.00 kB 300.05 kB +∞% 0.00 kB 56.73 kB
oss-experimental/react-markup/index.js +∞% 0.00 kB 0.20 kB +∞% 0.00 kB 0.15 kB
oss-experimental/react-markup/react-markup.react-server.js +∞% 0.00 kB 0.23 kB +∞% 0.00 kB 0.15 kB
oss-experimental/react-html/cjs/react-html.development.js Deleted 341.64 kB 0.00 kB Deleted 62.38 kB 0.00 kB
oss-experimental/react-html/cjs/react-html.production.js Deleted 203.03 kB 0.00 kB Deleted 38.23 kB 0.00 kB
oss-experimental/react-html/cjs/react-html.react-server.development.js Deleted 497.36 kB 0.00 kB Deleted 89.52 kB 0.00 kB
oss-experimental/react-html/cjs/react-html.react-server.production.js Deleted 300.05 kB 0.00 kB Deleted 56.73 kB 0.00 kB
oss-experimental/react-html/index.js Deleted 0.20 kB 0.00 kB Deleted 0.14 kB 0.00 kB
oss-experimental/react-html/react-html.react-server.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-markup/cjs/react-markup.development.js +∞% 0.00 kB 341.64 kB +∞% 0.00 kB 62.38 kB
oss-experimental/react-markup/cjs/react-markup.production.js +∞% 0.00 kB 203.03 kB +∞% 0.00 kB 38.23 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js +∞% 0.00 kB 497.36 kB +∞% 0.00 kB 89.52 kB
oss-experimental/react-markup/cjs/react-markup.react-server.production.js +∞% 0.00 kB 300.05 kB +∞% 0.00 kB 56.73 kB
oss-experimental/react-markup/index.js +∞% 0.00 kB 0.20 kB +∞% 0.00 kB 0.15 kB
oss-experimental/react-markup/react-markup.react-server.js +∞% 0.00 kB 0.23 kB +∞% 0.00 kB 0.15 kB
oss-experimental/react-html/cjs/react-html.development.js Deleted 341.64 kB 0.00 kB Deleted 62.38 kB 0.00 kB
oss-experimental/react-html/cjs/react-html.production.js Deleted 203.03 kB 0.00 kB Deleted 38.23 kB 0.00 kB
oss-experimental/react-html/cjs/react-html.react-server.development.js Deleted 497.36 kB 0.00 kB Deleted 89.52 kB 0.00 kB
oss-experimental/react-html/cjs/react-html.react-server.production.js Deleted 300.05 kB 0.00 kB Deleted 56.73 kB 0.00 kB
oss-experimental/react-html/index.js Deleted 0.20 kB 0.00 kB Deleted 0.14 kB 0.00 kB
oss-experimental/react-html/react-html.react-server.js Deleted 0.22 kB 0.00 kB Deleted 0.15 kB 0.00 kB

Generated by 🚫 dangerJS against 3e7b8e4

@eps1lon eps1lon marked this pull request as ready for review August 14, 2024 17:22
@eps1lon eps1lon merged commit e0a0e65 into facebook:main Aug 14, 2024
@eps1lon eps1lon deleted the sebbie/react-markup/publishable branch August 14, 2024 17:23
@eps1lon eps1lon changed the title Move react-html to react-markup [Fax] Move react-html to react-markup Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants