Skip to content

[compiler] Don't error on ref-in-render on StartMemoize #30715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 16, 2024
Merged

[compiler] Don't error on ref-in-render on StartMemoize #30715

merged 5 commits into from
Aug 16, 2024

Conversation

@mvitousek
Copy link
Contributor

@mvitousek mvitousek commented Aug 15, 2024 •
edited
Loading

@mvitousek
[compiler] Don't error on ref-in-render on StartMemoize
ab668d5 
Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
@vercel
Copy link

vercel bot commented Aug 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 5:16pm

This was referenced Aug 15, 2024
Merged
Merged
Merged
@mvitousek
Update on "[compiler] Don't error on ref-in-render on StartMemoize"
4de184f 
Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
josephsavona
josephsavona approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice

...el-plugin-react-compiler/src/__tests__/fixtures/compiler/useCallback-ref-in-render.expect.md Outdated
```

### Eval output
(kind: exception) useRef is not defined No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@mvitousek
Update on "[compiler] Don't error on ref-in-render on StartMemoize"
2de6015 
Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
This was referenced Aug 16, 2024
Merged
Merged
@mvitousek
Update on "[compiler] Don't error on ref-in-render on StartMemoize"
0ce4742 
Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
@mvitousek
Update on "[compiler] Don't error on ref-in-render on StartMemoize"
ce0887f 
Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

[ghstack-poisoned]
@mvitousek mvitousek merged commit ce0887f into gh/mvitousek/27/base Aug 16, 2024
mvitousek added a commit that referenced this pull request Aug 16, 2024
@mvitousek
[compiler] Don't error on ref-in-render on StartMemoize
8a53160 
Test Plan:
Fixes the previous issue: ref enforcement ignores memoization marker instructions

ghstack-source-id: f35d6a6
Pull Request resolved: #30715
@mvitousek mvitousek deleted the gh/mvitousek/27/head branch August 16, 2024 17:28
@eps1lon eps1lon mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephsavona josephsavona josephsavona approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mvitousek @josephsavona @facebook-github-bot