Skip to content

Conversation

poteto
Copy link
Member

@poteto poteto commented Aug 21, 2024

Stack from ghstack (oldest at bottom):

These are only needed internally so I'm opting to just do it in the
commit artifacts job instead of amending the build config.

[ghstack-poisoned]
@vercel
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 3:44pm

poteto added a commit that referenced this pull request Aug 21, 2024
These are only needed internally so I'm opting to just do it in the
commit artifacts job instead of amending the build config.

ghstack-source-id: 6a5382b
Pull Request resolved: #30775
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 21, 2024
@react-sizebot
Copy link

Comparing: ab24f64...1927063

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e9f5d77

@poteto poteto merged commit e9f5d77 into gh/poteto/4/base Aug 21, 2024
poteto added a commit that referenced this pull request Aug 21, 2024
These are only needed internally so I'm opting to just do it in the
commit artifacts job instead of amending the build config.

ghstack-source-id: 6a5382b
Pull Request resolved: #30775
@poteto poteto deleted the gh/poteto/4/head branch August 21, 2024 15:49
github-actions bot pushed a commit that referenced this pull request Aug 21, 2024
These are only needed internally so I'm opting to just do it in the
commit artifacts job instead of amending the build config.

ghstack-source-id: 6a5382b
Pull Request resolved: #30775

DiffTrain build for [1d98996](1d98996)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants