Revert "[compiler][eslint] remove compilationMode override; report bailouts on first line" #30792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Aug 22, 2024
…ilouts on first line" This reverts commit b34b750. This hack doesn't play well internally so I'm reverting this for now (but keeping the compilationMode override). I'll audit the locations we report later and try to make them more accurate so we won't need this workaround. ghstack-source-id: b6be29c Pull Request resolved: #30792
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
approved these changes
Aug 22, 2024
poteto
added a commit
that referenced
this pull request
Aug 22, 2024
…ilouts on first line" This reverts commit b34b750. This hack doesn't play well internally so I'm reverting this for now (but keeping the compilationMode override). I'll audit the locations we report later and try to make them more accurate so we won't need this workaround. ghstack-source-id: b6be29c Pull Request resolved: #30792
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This reverts commit b34b750.
This hack doesn't play well internally so I'm reverting this for now
(but keeping the compilationMode override). I'll audit the locations we
report later and try to make them more accurate so we won't need this
workaround.