- 
                Notifications
    You must be signed in to change notification settings 
- Fork 49.7k
[compiler] Handle optional where innermost property access is non-optional #30836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
        
      
            josephsavona
  merged 3 commits into
  gh/josephsavona/54/base
from
gh/josephsavona/54/head
  
      
      
   
  Aug 28, 2024 
      
    
                
     Merged
            
            [compiler] Handle optional where innermost property access is non-optional #30836
                    josephsavona
  merged 3 commits into
  gh/josephsavona/54/base
from
gh/josephsavona/54/head
  
      
      
   
  Aug 28, 2024 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …ional Handles an additional case as part of testing combinations of the same path being accessed in different places with different segments as optional/unconditional. [ghstack-poisoned]
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 
 | 
  This was referenced Aug 27, 2024 
      
  This was referenced Aug 27, 2024 
      
… is non-optional" Handles an additional case as part of testing combinations of the same path being accessed in different places with different segments as optional/unconditional. [ghstack-poisoned]
… is non-optional" Handles an additional case as part of testing combinations of the same path being accessed in different places with different segments as optional/unconditional. [ghstack-poisoned]
            
                  mofeiZ
  
            
            approved these changes
            
                
                  Aug 28, 2024 
                
            
            
          
          
  This was referenced Aug 29, 2024 
      
  This was referenced Sep 5, 2024 
      
  This was referenced Sep 9, 2024 
      
    
  gnoff 
      pushed a commit
        to vercel/next.js
      that referenced
      this pull request
    
      Sep 12, 2024 
    
    
      
  
    
      
    
  
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-7771d3a7-20240827` to `19.0.0-rc-94e652d5-20240912`** [diff facebook/react@7771d3a7...94e652d5](facebook/react@7771d3a...94e652d) <details> <summary>React upstream changes</summary> - facebook/react#30952 - facebook/react#30950 - facebook/react#30946 - facebook/react#30934 - facebook/react#30947 - facebook/react#30945 - facebook/react#30938 - facebook/react#30936 - facebook/react#30879 - facebook/react#30888 - facebook/react#30931 - facebook/react#30930 - facebook/react#30832 - facebook/react#30929 - facebook/react#30926 - facebook/react#30925 - facebook/react#30905 - facebook/react#30900 - facebook/react#30910 - facebook/react#30906 - facebook/react#30899 - facebook/react#30919 - facebook/react#30708 - facebook/react#30907 - facebook/react#30897 - facebook/react#30896 - facebook/react#30895 - facebook/react#30887 - facebook/react#30889 - facebook/react#30893 - facebook/react#30892 - facebook/react#30891 - facebook/react#30882 - facebook/react#30881 - facebook/react#30870 - facebook/react#30849 - facebook/react#30878 - facebook/react#30865 - facebook/react#30869 - facebook/react#30875 - facebook/react#30800 - facebook/react#30762 - facebook/react#30831 - facebook/react#30866 - facebook/react#30853 - facebook/react#30850 - facebook/react#30847 - facebook/react#30842 - facebook/react#30837 - facebook/react#30848 - facebook/react#30844 - facebook/react#30839 - facebook/react#30802 - facebook/react#30841 - facebook/react#30827 - facebook/react#30826 - facebook/react#30825 - facebook/react#30824 - facebook/react#30840 - facebook/react#30838 - facebook/react#30836 - facebook/react#30819 - facebook/react#30816 - facebook/react#30814 - facebook/react#30813 - facebook/react#30812 - facebook/react#30811 </details> --------- Co-authored-by: vercel-release-bot <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Stack from ghstack (oldest at bottom):
Handles an additional case as part of testing combinations of the same path being accessed in different places with different segments as optional/unconditional.