Skip to content

Conversation

@poteto
Copy link
Member

@poteto poteto commented Sep 24, 2024

Stack from ghstack (oldest at bottom):

It seems like the github.event.workflow_run payload is only populated
for non manual runs of the workflow, so this would crash the manual
dispatch

Test plan: https://github.com/facebook/react/actions/runs/11017512571
completes

[ghstack-poisoned]
@vercel
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:09pm

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Sep 24, 2024
@react-sizebot
Copy link

react-sizebot commented Sep 24, 2024

Comparing: db320ea...e6a2463

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 507.20 kB 507.20 kB = 90.80 kB 90.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 512.13 kB 512.13 kB = 91.52 kB 91.52 kB
facebook-www/ReactDOM-prod.classic.js = 603.73 kB 603.73 kB = 106.83 kB 106.84 kB
facebook-www/ReactDOM-prod.modern.js = 579.95 kB 579.95 kB = 102.92 kB 102.92 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4504c0c

[ghstack-poisoned]
@poteto poteto changed the title [ci] Fix missing user name during manual workflow dispatch [ci] Fix missing values during manual workflow dispatch Sep 24, 2024
[ghstack-poisoned]
[ghstack-poisoned]
@poteto poteto merged commit 4504c0c into gh/poteto/6/base Sep 26, 2024
187 checks passed
poteto added a commit that referenced this pull request Sep 26, 2024
It seems like the github.event.workflow_run payload is only populated
for non manual runs of the workflow, so this would crash the manual
dispatch

Test plan: https://github.com/facebook/react/actions/runs/11017512571
completes

ghstack-source-id: fce02b1
Pull Request resolved: #31045
@poteto poteto deleted the gh/poteto/6/head branch September 26, 2024 14:20
gnoff added a commit to vercel/next.js that referenced this pull request Sep 27, 2024
abhi12299 pushed a commit to abhi12299/next.js that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants