Skip to content

[rcr] Remove runtimeModule compiler option #31055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

[rcr] Remove runtimeModule compiler option #31055

wants to merge 16 commits into from

Conversation

@poteto
Copy link
Member

@poteto poteto commented Sep 24, 2024 •
edited
Loading

@poteto
Update
60c4e63 
[ghstack-poisoned]
@vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 6:59pm

This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
Closed
poteto added a commit that referenced this pull request Sep 24, 2024
@poteto
[rcr] Remove runtimeModule compiler option
4e359ba 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: f0c73da
Pull Request resolved: #31055
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 24, 2024
poteto added a commit that referenced this pull request Sep 24, 2024
@poteto
[rcr] Remove runtimeModule compiler option
6febb68 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: f0c73da
Pull Request resolved: #31055
@poteto
Update
29f1329 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 24, 2024
@poteto
[rcr] Remove runtimeModule compiler option
6a09b10 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: b6990b2
Pull Request resolved: #31055
@poteto
Update
47cdefa 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 26, 2024
@poteto
[rcr] Remove runtimeModule compiler option
5f4eff9 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 0c65d96
Pull Request resolved: #31055
@poteto
Update
5c01aad 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 26, 2024
@poteto
[rcr] Remove runtimeModule compiler option
3232c83 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 159d6c4
Pull Request resolved: #31055
@poteto
Update
9ca2c4a 
[ghstack-poisoned]
@poteto poteto mentioned this pull request Sep 26, 2024
Closed
poteto added a commit that referenced this pull request Sep 26, 2024
@poteto
[rcr] Remove runtimeModule compiler option
d832837 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 85e32a6
Pull Request resolved: #31055
@poteto
Update
46acabf 
[ghstack-poisoned]
@poteto poteto mentioned this pull request Sep 26, 2024
Merged
poteto added a commit that referenced this pull request Sep 26, 2024
@poteto
[rcr] Remove runtimeModule compiler option
ca4aab7 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: c12286c
Pull Request resolved: #31055
@poteto
rebase
229a882 
[ghstack-poisoned]
@poteto
Update
9e71458 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 27, 2024
@poteto
[rcr] Remove runtimeModule compiler option
e6926c4 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: b8d31c1
Pull Request resolved: #31055
@poteto
Update
dc1f490 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 27, 2024
@poteto
[rcr] Remove runtimeModule compiler option
7504b22 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: d0c9cc9
Pull Request resolved: #31055
@poteto
Update
e82c1cc 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 27, 2024
@poteto
[rcr] Remove runtimeModule compiler option
2ff8deb 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 788fd4f
Pull Request resolved: #31055
@poteto
Update
1912000 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Sep 27, 2024
@poteto
[rcr] Remove runtimeModule compiler option
544191c 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 93379c6
Pull Request resolved: #31055
@josephsavona
Copy link
Member

Hmmm feels like we might want to keep this option for use internally where we're always on latest?

@poteto
Update
026ba4e 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Oct 1, 2024
@poteto
[rcr] Remove runtimeModule compiler option
1bfdbda 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: d8f7403
Pull Request resolved: #31055
@poteto
Copy link
Member Author

poteto commented Oct 1, 2024

@josephsavona hmm the new react-compiler-runtime already defers to the latest impl, and with this stack it's always added as a dep in codegen so this option isn't really necessary anymore

@poteto
Update
b8f628f 
[ghstack-poisoned]
poteto added a commit that referenced this pull request Oct 1, 2024
@poteto
[rcr] Remove runtimeModule compiler option
5004927 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 7ce2b97
Pull Request resolved: #31055
poteto added a commit that referenced this pull request Oct 1, 2024
@poteto
[rcr] Remove runtimeModule compiler option
c729d99 
Now that the compiler always injects `react-compiler-runtime`, this
option is unnecessary.

ghstack-source-id: 7ce2b97
Pull Request resolved: #31055
@poteto
Update
e3b0f2b 
[ghstack-poisoned]
@poteto poteto mentioned this pull request Oct 1, 2024
Closed
@poteto poteto marked this pull request as ready for review October 1, 2024 18:27
@poteto
Update
3e192c3 
[ghstack-poisoned]
@poteto
Update
0dcc910 
[ghstack-poisoned]
@poteto poteto closed this Oct 7, 2024
@poteto poteto deleted the gh/poteto/14/head branch November 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@poteto @josephsavona @facebook-github-bot