[Fiber] Fix missing render times when we cancel a pending commit

[eps1lon]

Summary

Follow-up to #31016

Fixes Failed to execute 'measure' on 'Performance': If a non-empty PerformanceMeasureOptions object was passed, at least one of its 'start' or 'end' properties must be present.

Not clear why we didn't catch this in our test suite. Probably because the performance polyfill does not throw if start and end are undefined when a non-empty PerformanceMeasureOptions is passed to performance.measure?

How did you test this change?

• Discovered when syncing latest React (Upgrade React from 5d19e1c8-20240923 to 04bd67a4-20240924 vercel/next.js#70407) where we encountered above bug. Patching the file locally made the test pass: vercel/next.js@744c429 (#70407)
• Also enhanced type to make it clear that you fn in waitForCommitToBeReady()(fn) does not receive any further arguments. With that change, the bug would've not get passed Flow. The error message isn't as clear as possible but it gives at least a hint that arguments are missing:

  $ yarn flow dom-node
  yarn run v1.22.22
  $ node ./scripts/tasks/flow.js dom-node
  Running Flow on the dom-node renderer...
  Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ packages/react-reconciler/src/ReactFiberWorkLoop.js:1315:9
  
  Cannot call schedulePendingCommit with commitRoot.bind(...) bound to the first
  parameter because function [1] requires another argument from function type [2].
  [incompatible-call]
  
      packages/react-reconciler/src/ReactFiberWorkLoop.js
      1312│       // us that it's ready. This will be canceled if we start work on the
      1313│       // root again.
      1314│       root.cancelPendingCommit = schedulePendingCommit(
      1315│         commitRoot.bind(
      1316│           null,
      1317│           root,
      1318│           recoverableErrors,
          :
  [1] 3054│ function commitRoot(
      3055│   root: FiberRoot,
      3056│   recoverableErrors: null | Array<CapturedValue<mixed>>,
      3057│   transitions: Array<Transition> | null,
      3058│   didIncludeRenderPhaseUpdate: boolean,
      3059│   spawnedLane: Lane,
      3060│   updatedLanes: Lanes,
      3061│   suspendedRetryLanes: Lanes,
      3062│   suspendedCommitReason: SuspendedCommitReason, // Profiling-only
      3063│   completedRenderStartTime: number, // Profiling-only
      3064│   completedRenderEndTime: number, // Profiling-only
      3065│ ) {
  
      packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js
  [2] 3404│ export function waitForCommitToBeReady(): null | ((() => any) => Function) {

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 9:20pm

[react-sizebot]

Comparing: 0f1856c...ed4adf3

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.68 kB	6.68 kB	=	1.83 kB	1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	+0.01%	507.15 kB	507.20 kB	+0.01%	90.79 kB	90.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.69 kB	6.69 kB	=	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	+0.01%	512.08 kB	512.13 kB	=	91.52 kB	91.52 kB
facebook-www/ReactDOM-prod.classic.js	=	603.67 kB	603.73 kB	=	106.83 kB	106.83 kB
facebook-www/ReactDOM-prod.modern.js	=	579.89 kB	579.95 kB	=	102.91 kB	102.92 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against fd8287f

[eps1lon]

This is unused and mostly removed to have strict types so that commitRoot is assignable to

react/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js

Line 3292 in 0f1856c

unsuspend: null | (() => void),