Skip to content

[compiler] Test fixture: non-reactive phi creates 'dangling ref' scope #31103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 10, 2024
Merged

[compiler] Test fixture: non-reactive phi creates 'dangling ref' scope #31103

merged 8 commits into from
Oct 10, 2024

Conversation

@mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Sep 30, 2024 •
edited
Loading

@mofeiZ
Update (base update)
75b4132 
[ghstack-poisoned]
@mofeiZ
Update
13e521b 
[ghstack-poisoned]
@mofeiZ mofeiZ mentioned this pull request Sep 30, 2024
Merged
@vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 3:51pm

This was referenced Sep 30, 2024
Merged
Merged
mofeiZ added a commit that referenced this pull request Sep 30, 2024
@mofeiZ
[compiler] Test fixture: non-reactive phi creates 'dangling ref' scope
347b95f 
ghstack-source-id: 2a6f36d
Pull Request resolved: #31103
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Sep 30, 2024
@mofeiZ
Update (base update)
056f726 
[ghstack-poisoned]
@mofeiZ
Update
f2c5877 
[ghstack-poisoned]
mofeiZ added a commit that referenced this pull request Sep 30, 2024
@mofeiZ
[compiler] Test fixture: non-reactive phi creates 'dangling ref' scope
096e343 
ghstack-source-id: 5dba5c0
Pull Request resolved: #31103
mofeiZ added 2 commits October 1, 2024 13:59
@mofeiZ
Update (base update)
52326e6 
[ghstack-poisoned]
@mofeiZ
Update
aaa3e2c 
[ghstack-poisoned]
mofeiZ added a commit that referenced this pull request Oct 1, 2024
@mofeiZ
[compiler] Test fixture: non-reactive phi creates 'dangling ref' scope
60e7744 
ghstack-source-id: dc8753a
Pull Request resolved: #31103
@mofeiZ mofeiZ mentioned this pull request Oct 3, 2024
Open
@mofeiZ mofeiZ marked this pull request as ready for review October 3, 2024 15:11
josephsavona
josephsavona approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super interesting. We should discuss what the fix is for this case

mofeiZ added 2 commits October 10, 2024 11:47
@mofeiZ
Update (base update)
4b7c660 
[ghstack-poisoned]
@mofeiZ
Update
b597f18 
[ghstack-poisoned]
@mofeiZ mofeiZ changed the base branch from gh/mofeiZ/24/base to main October 10, 2024 15:47
@mofeiZ mofeiZ merged commit fbfe37e into main Oct 10, 2024
19 checks passed
This was referenced Oct 10, 2024
Merged
Closed
Testmasha pushed a commit to Testmasha/Test that referenced this pull request Apr 15, 2025
@mofeiZ
[compiler] Test fixture: non-reactive phi creates 'dangling ref' scope
616d45c 
ghstack-source-id: 8a6e2ad
Pull Request resolved: facebook/react#31103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephsavona josephsavona josephsavona approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mofeiZ @josephsavona @facebook-github-bot