Skip to content

Capture the source and not just the stack on first seen error #31367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

Capture the source and not just the stack on first seen error #31367

merged 1 commit into from
Oct 28, 2024
+102 −21

Conversation

@sebmarkbage
Copy link
Collaborator

Otherwise we can't capture the owner stack at the right location when there's a rethrow.

@sebmarkbage
Capture the source and not just the stack on first seen error
6caeb3a 
Otherwise we can't capture the owner stack at the right location.
@sebmarkbage sebmarkbage requested review from eps1lon and gnoff October 27, 2024 00:03
@vercel
Copy link

vercel bot commented Oct 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 0:06am

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 27, 2024
@react-sizebot
Copy link

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against 6caeb3a

@sebmarkbage sebmarkbage merged commit 0bc3074 into facebook:main Oct 28, 2024
184 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
@sebmarkbage
Capture the source and not just the stack on first seen error (#31367)
84a3f07 
Otherwise we can't capture the owner stack at the right location when
there's a rethrow.

DiffTrain build for [0bc3074](0bc3074)
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
@sebmarkbage
Capture the source and not just the stack on first seen error (#31367)
0fb655b 
Otherwise we can't capture the owner stack at the right location when
there's a rethrow.

DiffTrain build for [0bc3074](0bc3074)
This was referenced Oct 29, 2024
Closed
Merged
@huozhi huozhi mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnoff gnoff gnoff approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebmarkbage @react-sizebot @gnoff @eps1lon @facebook-github-bot