[compiler] Check if local identifier is a hook when resolving globals #31384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
This was originally reported in reactwg/react-compiler#27. Adding a failing repro to capture this case.
When resolving import specifiers from the react namespace (`import {imported as local} from 'react'`), we were previously only checking if the `imported` identifier was a hook if we didn't already have its definition in the global registry. We also need to check if `local` is a hook in the case of aliasing since there may be hook-like APIs in react that don't start with `use` (eg they are experimental or unstable).
Comment on lines
+855
to
+857
| (isHookName(binding.imported) || isHookName(binding.name) | ||
| ? this.#getCustomHookType() | ||
| : null) |
Member
There was a problem hiding this comment.
We should probably also just define all the APIs, including unstable ones. But this is pretty reasonable. Thanks!
josephsavona
approved these changes
Oct 29, 2024
poteto
added a commit
that referenced
this pull request
Oct 30, 2024
#31383) This was originally reported in reactwg/react-compiler#27. Adding a failing repro to capture this case. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31383). * #31385 * #31384 * __->__ #31383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving import specifiers from the react namespace (
import {imported as local} from 'react'), we were previously only checking if theimportedidentifier was a hook if we didn't already have its definition in the global registry. We also need to check iflocalis a hook in the case of aliasing since there may be hook-like APIs in react that don't start withuse(eg they are experimental or unstable).Stack created with Sapling. Best reviewed with ReviewStack.