eslint-plugin-react-hooks: Fix international component name compatibility #31456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DavidZidar
force-pushed
the
fix-rulesofhooks
branch
from
8793478 to
da69c91
Compare
|
Q |
DavidZidar
force-pushed
the
fix-rulesofhooks
branch
from
da69c91 to
8a78051
Compare
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
|
Bump, the issue still isn't solved. |
github-actions
bot
removed
the
Resolution: Stale
|
Bump (I'd really like to see this work get merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes compatiblity with international functional component names such as
ÄndraVärdein the ESLint ruleRulesOfHooks.The problem is a Regex that only allows component names to start with the characters A-Z when in reality characters from other languages should be supported too.
Fixes #31446
How did you test this change?
I added a unit test and verified that the rule failed just like it does in my own projects, then I did my modification and verified that the tests pass.