[compiler][ez] rewrite invariant in InferReferenceEffects #32093
+49
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
facebook-github-bot
added
the
React Core Team
This was referenced Jan 16, 2025
Small patch to pass aliased context values into `Object|ArrayExpression`s
mofeiZ
changed the title
josephsavona
approved these changes
Jan 21, 2025
Comment on lines
+860
to
+872
| const contextRefOperands = getContextRefOperand(state, instrValue); | ||
| const valueKind: AbstractValue = | ||
| contextRefOperands.length > 0 | ||
| ? { | ||
| kind: ValueKind.Context, | ||
| reason: new Set([ValueReason.Other]), | ||
| context: new Set(contextRefOperands), | ||
| } | ||
| : { | ||
| kind: ValueKind.Mutable, | ||
| reason: new Set([ValueReason.Other]), | ||
| context: new Set(), | ||
| }; |
There was a problem hiding this comment.
Hmmm it seems wrong to do this only for array and object expressions: there could just as easily be a function call or constructor that captures context values in the same way. I think we missed this when we originally added the context ref check — let's generalize this check
There was a problem hiding this comment.
Just slightly ahead of you, see repro here #31770
+1 on generalizing this check -- although I'm curious how many changes to compilation output this would result in
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
See test fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32094). * #32099 * #32104 * #32098 * #32097 * #32096 * #32095 * __->__ #32094 * #32093
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
See test fixture --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32095). * #32099 * #32104 * #32098 * #32097 * #32096 * __->__ #32095 * #32094 * #32093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch to pass aliased context values into
Object|ArrayExpressionsStack created with Sapling. Best reviewed with ReviewStack.