Skip to content

Set enableViewTransition to dynamic for www #32306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

Set enableViewTransition to dynamic for www #32306

merged 1 commit into from
Feb 4, 2025

Conversation

jackpope
Copy link
Contributor

@jackpope jackpope commented Feb 4, 2025

Unblocks internal experimentation

@jackpope jackpope requested a review from sebmarkbage February 4, 2025 19:00
@jackpope jackpope requested a review from rickhanlonii February 4, 2025 19:01
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 4, 2025
@react-sizebot
Copy link

Comparing: 0a82580...b1e4ad8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 514.52 kB 514.52 kB = 91.76 kB 91.76 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 557.55 kB 557.55 kB = 99.01 kB 99.01 kB
facebook-www/ReactDOM-prod.classic.js +6.52% 596.50 kB 635.37 kB +6.35% 104.89 kB 111.55 kB
facebook-www/ReactDOM-prod.modern.js +6.60% 586.92 kB 625.69 kB +6.41% 103.35 kB 109.97 kB
facebook-www/ReactReconciler-prod.modern.js +7.37% 451.70 kB 484.98 kB +6.82% 72.58 kB 77.53 kB
facebook-www/ReactReconciler-prod.classic.js +7.23% 461.85 kB 495.25 kB +6.71% 74.14 kB 79.12 kB
facebook-www/ReactDOMTesting-prod.modern.js +6.44% 601.64 kB 640.40 kB +6.20% 107.04 kB 113.68 kB
facebook-www/ReactDOM-profiling.modern.js +6.37% 613.93 kB 653.05 kB +6.25% 107.20 kB 113.90 kB
facebook-www/ReactDOMTesting-prod.classic.js +6.36% 611.21 kB 650.09 kB +6.16% 108.58 kB 115.27 kB
facebook-www/ReactDOM-profiling.classic.js +6.29% 623.56 kB 662.78 kB +6.17% 108.78 kB 115.49 kB
facebook-www/ReactReconciler-dev.modern.js +4.98% 727.89 kB 764.17 kB +4.64% 114.63 kB 119.94 kB
facebook-www/ReactReconciler-dev.classic.js +4.92% 737.10 kB 773.38 kB +4.58% 116.30 kB 121.62 kB
facebook-www/ReactART-prod.modern.js +4.62% 357.20 kB 373.71 kB +4.83% 59.86 kB 62.76 kB
facebook-www/ReactART-prod.classic.js +4.53% 367.03 kB 383.65 kB +4.72% 61.45 kB 64.35 kB
facebook-www/ReactDOM-dev.modern.js +4.28% 1,062.33 kB 1,107.79 kB +4.15% 176.99 kB 184.34 kB
facebook-www/ReactDOM-dev.classic.js +4.24% 1,071.47 kB 1,116.93 kB +4.12% 178.70 kB 186.07 kB
facebook-www/ReactDOMTesting-dev.modern.js +4.21% 1,079.23 kB 1,124.69 kB +4.05% 180.89 kB 188.21 kB
facebook-www/ReactDOMTesting-dev.classic.js +4.18% 1,088.38 kB 1,133.84 kB +4.02% 182.60 kB 189.94 kB
facebook-www/ReactART-dev.modern.js +2.98% 640.25 kB 659.33 kB +3.00% 101.46 kB 104.50 kB
facebook-www/ReactART-dev.classic.js +2.94% 649.75 kB 668.83 kB +2.98% 103.27 kB 106.35 kB
facebook-www/ReactIs-prod.classic.js +2.32% 5.85 kB 5.99 kB +1.53% 1.37 kB 1.39 kB
facebook-www/ReactIs-prod.modern.js +2.32% 5.85 kB 5.99 kB +1.53% 1.37 kB 1.39 kB
facebook-www/ReactIs-dev.classic.js +2.04% 6.46 kB 6.59 kB +1.43% 1.40 kB 1.42 kB
facebook-www/ReactIs-dev.modern.js +2.04% 6.46 kB 6.59 kB +1.43% 1.40 kB 1.42 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactReconciler-prod.modern.js +7.37% 451.70 kB 484.98 kB +6.82% 72.58 kB 77.53 kB
facebook-www/ReactReconciler-prod.classic.js +7.23% 461.85 kB 495.25 kB +6.71% 74.14 kB 79.12 kB
facebook-www/ReactDOM-prod.modern.js +6.60% 586.92 kB 625.69 kB +6.41% 103.35 kB 109.97 kB
facebook-www/ReactDOM-prod.classic.js +6.52% 596.50 kB 635.37 kB +6.35% 104.89 kB 111.55 kB
facebook-www/ReactDOMTesting-prod.modern.js +6.44% 601.64 kB 640.40 kB +6.20% 107.04 kB 113.68 kB
facebook-www/ReactDOM-profiling.modern.js +6.37% 613.93 kB 653.05 kB +6.25% 107.20 kB 113.90 kB
facebook-www/ReactDOMTesting-prod.classic.js +6.36% 611.21 kB 650.09 kB +6.16% 108.58 kB 115.27 kB
facebook-www/ReactDOM-profiling.classic.js +6.29% 623.56 kB 662.78 kB +6.17% 108.78 kB 115.49 kB
facebook-www/ReactReconciler-dev.modern.js +4.98% 727.89 kB 764.17 kB +4.64% 114.63 kB 119.94 kB
facebook-www/ReactReconciler-dev.classic.js +4.92% 737.10 kB 773.38 kB +4.58% 116.30 kB 121.62 kB
facebook-www/ReactART-prod.modern.js +4.62% 357.20 kB 373.71 kB +4.83% 59.86 kB 62.76 kB
facebook-www/ReactART-prod.classic.js +4.53% 367.03 kB 383.65 kB +4.72% 61.45 kB 64.35 kB
facebook-www/ReactDOM-dev.modern.js +4.28% 1,062.33 kB 1,107.79 kB +4.15% 176.99 kB 184.34 kB
facebook-www/ReactDOM-dev.classic.js +4.24% 1,071.47 kB 1,116.93 kB +4.12% 178.70 kB 186.07 kB
facebook-www/ReactDOMTesting-dev.modern.js +4.21% 1,079.23 kB 1,124.69 kB +4.05% 180.89 kB 188.21 kB
facebook-www/ReactDOMTesting-dev.classic.js +4.18% 1,088.38 kB 1,133.84 kB +4.02% 182.60 kB 189.94 kB
facebook-www/ReactART-dev.modern.js +2.98% 640.25 kB 659.33 kB +3.00% 101.46 kB 104.50 kB
facebook-www/ReactART-dev.classic.js +2.94% 649.75 kB 668.83 kB +2.98% 103.27 kB 106.35 kB
facebook-www/ReactIs-prod.classic.js +2.32% 5.85 kB 5.99 kB +1.53% 1.37 kB 1.39 kB
facebook-www/ReactIs-prod.modern.js +2.32% 5.85 kB 5.99 kB +1.53% 1.37 kB 1.39 kB
facebook-www/ReactIs-dev.classic.js +2.04% 6.46 kB 6.59 kB +1.43% 1.40 kB 1.42 kB
facebook-www/ReactIs-dev.modern.js +2.04% 6.46 kB 6.59 kB +1.43% 1.40 kB 1.42 kB
facebook-www/JSXDEVRuntime-dev.classic.js +1.23% 28.44 kB 28.79 kB +0.66% 6.68 kB 6.73 kB
facebook-www/JSXDEVRuntime-dev.modern.js +1.23% 28.44 kB 28.79 kB +0.66% 6.68 kB 6.73 kB
facebook-react-native/react/cjs/React-prod.js +0.68% 19.12 kB 19.25 kB +0.70% 4.98 kB 5.01 kB
facebook-react-native/react/cjs/React-profiling.js +0.66% 19.55 kB 19.68 kB +0.73% 5.05 kB 5.09 kB
facebook-www/React-prod.modern.js +0.63% 20.63 kB 20.76 kB +0.66% 5.29 kB 5.32 kB
facebook-www/React-prod.classic.js +0.63% 20.63 kB 20.76 kB +0.66% 5.29 kB 5.32 kB
facebook-www/React-profiling.modern.js +0.62% 21.07 kB 21.20 kB +0.65% 5.37 kB 5.40 kB
facebook-www/React-profiling.classic.js +0.62% 21.07 kB 21.20 kB +0.65% 5.37 kB 5.40 kB
facebook-www/React-dev.modern.js +0.59% 71.02 kB 71.44 kB +0.26% 15.50 kB 15.54 kB
facebook-www/React-dev.classic.js +0.59% 71.02 kB 71.44 kB +0.26% 15.50 kB 15.54 kB
facebook-www/ReactDOMServer-prod.modern.js +0.22% 217.07 kB 217.55 kB +0.10% 39.30 kB 39.34 kB
facebook-www/ReactDOMServer-prod.classic.js +0.22% 219.75 kB 220.24 kB +0.13% 39.63 kB 39.68 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.22% 221.38 kB 221.87 kB +0.10% 40.93 kB 40.96 kB
facebook-react-native/react/cjs/React-dev.js +0.21% 66.71 kB 66.85 kB +0.25% 14.68 kB 14.72 kB

Generated by 🚫 dangerJS against e5b6148

@jackpope jackpope merged commit 32b4114 into facebook:main Feb 4, 2025
193 checks passed
@jackpope jackpope deleted the enable-view-transitions-flag branch February 4, 2025 20:53
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
@jackpope
Set enableViewTransition to dynamic for www (#32306)
96aa3ad 
Unblocks internal experimentation

DiffTrain build for [32b4114](32b4114)
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
@jackpope
Set enableViewTransition to dynamic for www (#32306)
ffbc049 
Unblocks internal experimentation

DiffTrain build for [32b4114](32b4114)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Feb 5, 2025
@pull
Set enableViewTransition to dynamic for www (facebook#32306)
aecca32 
Unblocks internal experimentation

DiffTrain build for [32b4114](facebook@32b4114)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Feb 5, 2025
@pull
Set enableViewTransition to dynamic for www (facebook#32306)
55a73e5 
Unblocks internal experimentation

DiffTrain build for [32b4114](facebook@32b4114)
This was referenced Feb 5, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope @react-sizebot @rickhanlonii @facebook-github-bot